Extension Error Piping - Blink: WebKit Side

Source/core/page/PageConsole.cpp

 /*
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 73 matching lines @@
         return;
 
     if (callStack)
         InspectorInstrumentation::addMessageToConsole(page, source, LogMessageType, level, message, callStack, requestIdentifier);
     else
         InspectorInstrumentation::addMessageToConsole(page, source, LogMessageType, level, message, url, lineNumber, columnNumber, state, requestIdentifier);
 
     if (source == CSSMessageSource)
         return;
 
-    page->chrome().client()->addMessageToConsole(source, level, message, lineNumber, url);
+    String stackTrace;
+    if (page->chrome().client()->shouldReportDetailedMessageForSource(url) && callStack)
+        stackTrace = formatStackTraceString(message, callStack);
+
+    page->chrome().client()->addMessageToConsole(source, level, message, lineNumber, url, stackTrace);
 }
 
 // static

[abarth-chromium, 2013/08/19 19:54:18]

Please remove these comments.  We don't use them in Blink.

[Devlin, 2013/08/19 20:24:58]

Done.

+String PageConsole::formatStackTraceString(const String& originalMessage, PassRefPtr<ScriptCallStack> callStack)
+{
+    String stackTrace;

[abarth-chromium, 2013/08/19 19:54:18]

Please don't ever call String::append.  It's horribly slow.  Instead, this
should be:

StringBuilder stackTrace;

and the last line of the function should be:

return stackTrace.toString();

[Devlin, 2013/08/19 20:24:58]

Done.

+    for (size_t i = 0; i < callStack->size(); ++i) {
+        const ScriptCallFrame& frame = callStack->at(i);
+        stackTrace.append("\n    at " + (frame.functionName().length() ? frame.functionName() : String("(anonymous function)")) + " (" + frame.sourceURL() + ":" + String::number(frame.lineNumber()) + ":" + String::number(frame.columnNumber()) + ")");

[abarth-chromium, 2013/08/19 19:54:18]

Rather than creating all these temporary strings, please just call
StringBuilder::append a bunch of times.  As written, this code is very
inefficient.

[Devlin, 2013/08/19 20:24:58]

Done.

+    }
+
+    return stackTrace;
+}
+
+// static
 void PageConsole::mute()
 {
     muteCount++;
 }
 
 // static
 void PageConsole::unmute()
 {
     ASSERT(muteCount > 0);
     muteCount--;
 }
 
 } // namespace WebCore