Extension Error Piping - Blink: WebKit Side

Source/core/page/PageConsole.cpp

 /*
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 19 matching lines @@
 #include "core/page/PageConsole.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/ScriptableDocumentParser.h"
 #include "core/inspector/ConsoleAPITypes.h"
 #include "core/inspector/InspectorConsoleInstrumentation.h"
 #include "core/inspector/ScriptCallStack.h"
 #include "core/page/Chrome.h"
 #include "core/page/ChromeClient.h"
 #include "core/page/ConsoleTypes.h"
+#include "core/page/FormatConsoleMessage.h"
 #include "core/page/Page.h"
 #include "wtf/text/WTFString.h"
 
 namespace WebCore {
 
 namespace {
 
 int muteCount = 0;
 
 }
@@ skipping 34 matching lines @@
         return;
 
     if (callStack)
         InspectorInstrumentation::addMessageToConsole(page, source, LogMessageType, level, message, callStack, requestIdentifier);
     else
         InspectorInstrumentation::addMessageToConsole(page, source, LogMessageType, level, message, url, lineNumber, columnNumber, state, requestIdentifier);
 
     if (source == CSSMessageSource)
         return;
 
-    page->chrome().client()->addMessageToConsole(source, level, message, lineNumber, url);
+    String chromeMessage;
+    if (page->chrome().client()->shouldReportDetailedMessageForSource(url)) {
+        if (callStack)
+            chromeMessage = formatConsoleMessage(message, callStack);
+        else
+            chromeMessage = formatConsoleMessage(message, url, lineNumber, columnNumber);
+    }
+    page->chrome().client()->addMessageToConsole(source, level, chromeMessage, lineNumber, url);

[pfeldman, 2013/08/14 09:53:00]

Wait, I thought we agreed on an additional text field with the stack trace.
Sorry for overseeing it at the first place.

[Devlin, 2013/08/14 17:00:40]

Okay.  Wasn't sure if plain-text should go with plain-text or not, and opted for
the one that changed fewer interfaces.  But having it as two arguments is good,
too.  Done.

 }
 
 // static
 void PageConsole::mute()
 {
     muteCount++;
 }
 
 // static
 void PageConsole::unmute()
 {
     ASSERT(muteCount > 0);
     muteCount--;
 }
 
 } // namespace WebCore