Extension Error Piping - Blink: WebKit Side

Source/core/page/PageConsole.cpp

 /*
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 73 matching lines @@
         return;
 
     if (callStack)
         InspectorInstrumentation::addMessageToConsole(page, source, LogMessageType, level, message, callStack, requestIdentifier);
     else
         InspectorInstrumentation::addMessageToConsole(page, source, LogMessageType, level, message, url, lineNumber, columnNumber, state, requestIdentifier);
 
     if (source == CSSMessageSource)
         return;
 
-    page->chrome().client()->addMessageToConsole(source, level, message, lineNumber, url);
+    String stackTrace;
+    if (page->chrome().client()->shouldReportDetailedMessage(url)) {
+        if (callStack) {
+            stackTrace = callStack->buildInspectorArray()->toJSONString();

[pfeldman, 2013/07/17 09:09:38]

You should instead format stack trace here, toJSONString that you are using
might change its structure at any time, so you want to handle stack -> text
conversion here (or come up with yet another class describing call stack in web
API).

[Devlin, 2013/07/17 22:14:13]

Done.

[Matt Perry, 2013/07/18 20:20:34]

I'm starting to think that we should add a callstack class. Passing structured
data in a string, and expecting both sides to agree on the format of the string,
seems a bit strange. OTOH, it's a lot of plumbing to ferry across a new
structured datatype (you'd need to transfer types at each boundary of
WebCore->WebKit->browser).

+        } else {
+            RefPtr<JSONObject> simpleStackFrame = JSONObject::create();
+            simpleStackFrame->setNumber("lineNumber", lineNumber);
+            simpleStackFrame->setNumber("columnNumber", columnNumber);
+            simpleStackFrame->setString("url", url);
+            RefPtr<JSONArray> simpleStackTrace = JSONArray::create();
+            simpleStackTrace->pushObject(simpleStackFrame);
+            stackTrace = simpleStackTrace->toJSONString();
+        }
+    }
+    page->chrome().client()->addMessageToConsole(source, level, message, lineNumber, url, stackTrace);
 }
 
 // static
 void PageConsole::mute()
 {
     muteCount++;
 }
 
 // static
 void PageConsole::unmute()
 {
     ASSERT(muteCount > 0);
     muteCount--;
 }
 
 } // namespace WebCore