Extension Error Piping - Blink: WebKit Side

Source/core/page/PageConsole.cpp

 /*
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 73 matching lines @@
         return;
 
     if (callStack)
         InspectorInstrumentation::addMessageToConsole(page, source, LogMessageType, level, message, callStack, requestIdentifier);
     else
         InspectorInstrumentation::addMessageToConsole(page, source, LogMessageType, level, message, url, lineNumber, columnNumber, state, requestIdentifier);
 
     if (source == CSSMessageSource)
         return;
 
-    page->chrome().client()->addMessageToConsole(source, level, message, lineNumber, url);
+    String chromeMessage = message;
+    if (page->chrome().client()->shouldReportDetailedMessageForSource(url)) {
+        if (callStack) {
+            for (size_t i = 0; i < callStack->size(); ++i) {

[pfeldman, 2013/08/12 16:15:34]

Can you extract this formatter and use it from Console.cpp?

[Devlin, 2013/08/12 19:38:17]

Done.

+                const ScriptCallFrame& frame = callStack->at(i);
+                chromeMessage.append("\n    at " + (frame.functionName().length() ? frame.functionName() : String("(anonymous function)")) + " (" + frame.sourceURL() + ":" + String::number(frame.lineNumber()) + ":" + String::number(frame.columnNumber()) + ")");
+            }
+        } else {
+            chromeMessage.append("\n    at (anonymous function) (" + url + ":" + String::number(lineNumber) + ":" + String::number(columnNumber) + ")");
+        }
+    }
+    page->chrome().client()->addMessageToConsole(source, level, chromeMessage, lineNumber, url);
 }
 
 // static
 void PageConsole::mute()
 {
     muteCount++;
 }
 
 // static
 void PageConsole::unmute()
 {
     ASSERT(muteCount > 0);
     muteCount--;
 }
 
 } // namespace WebCore