Extension Error Piping - Blink: WebKit Side

public/web/WebViewClient.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 27 matching lines @@
 #include "WebContentDetectionResult.h"
 #include "WebDragOperation.h"
 #include "WebEditingAction.h"
 #include "WebFileChooserCompletion.h"
 #include "WebFileChooserParams.h"
 #include "WebPageVisibilityState.h"
 #include "WebPopupType.h"
 #include "WebTextAffinity.h"
 #include "WebTextDirection.h"
 #include "WebWidgetClient.h"
+#include <v8.h>

[abarth-chromium, 2013/07/19 03:12:17]

Hum...  This is suspicious.  We probably don't want to introduce V8 concepts
into this interface.

 
 namespace WebKit {
 
 class WebAccessibilityObject;
 class WebColorChooser;
 class WebColorChooserClient;
 class WebCompositorOutputSurface;
 class WebDateTimeChooserCompletion;
 class WebDeviceOrientationClient;
 class WebDragData;
@@ skipping 61 matching lines @@
     virtual WebWidget* createPopupMenu(const WebPopupMenuInfo&) { return 0; }
     virtual WebExternalPopupMenu* createExternalPopupMenu(
         const WebPopupMenuInfo&, WebExternalPopupMenuClient*) { return 0; }
 
     // Create a session storage namespace object associated with this WebView.
     virtual WebStorageNamespace* createSessionStorageNamespace() { return 0; }
 
 
     // Misc ----------------------------------------------------------------
 
-    // A new message was added to the console.
+    // Whether or not we should report a detailed message for the given source.
+    virtual bool shouldReportDetailedMessageForContext(v8::Handle<v8::Context>) { return false; }
+    virtual bool shouldReportDetailedMessageForURL(const WebString& source) { return false; }
+
+    // A new message was added to the console. If a detailed message should be
+    // reported, a stringified JSON object is included; otherwise, |details| is
+    // empty.
     virtual void didAddMessageToConsole(
-        const WebConsoleMessage&, const WebString& sourceName, unsigned sourceLine) { }
+        const WebConsoleMessage&, const WebString& sourceName,
+        unsigned sourceLine, const WebString& details) { }
 
     // Called when script in the page calls window.print().  If frame is
     // non-null, then it selects a particular frame, including its
     // children, to print.  Otherwise, the main frame and its children
     // should be printed.
     virtual void printPage(WebFrame*) { }
 
     // Called to retrieve the provider of desktop notifications.
     virtual WebNotificationPresenter* notificationPresenter() { return 0; }
 
@@ skipping 254 matching lines @@
     // Informs the browser that the draggable regions have been updated.
     virtual void draggableRegionsChanged() { }
 
 protected:
     ~WebViewClient() { }
 };
 
 } // namespace WebKit
 
 #endif