Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1882143005: Add dummy -j flags to pixel and javascript test runners (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Add dummy -j flags to pixel and javascript test runners This is an intermediate step to creating a unified test runner. We need to update Dr Memory to pass the -j 1 flag to the pixel and javascript tests. In order to do so, we need to have the flag available. The flag will be enabled for pixel and javascript tests when [1] lands. 1- https://codereview.chromium.org/1886753002/ Committed: https://pdfium.googlesource.com/pdfium/+/a654f0d0889c50d0995bd873c119ae75b0ab5a09

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M testing/tools/run_javascript_tests.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M testing/tools/run_pixel_tests.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-13 17:41:34 UTC) #2
Tom Sepez
Add a explanation to the CL description about what the buys us. LGTM otherwise. https://codereview.chromium.org/1882143005/diff/1/testing/tools/run_javascript_tests.py ...
4 years, 8 months ago (2016-04-13 17:52:43 UTC) #3
dsinclair
On 2016/04/13 17:52:43, Tom Sepez wrote: > Add a explanation to the CL description about ...
4 years, 8 months ago (2016-04-13 17:56:00 UTC) #5
dsinclair
https://codereview.chromium.org/1882143005/diff/1/testing/tools/run_javascript_tests.py File testing/tools/run_javascript_tests.py (right): https://codereview.chromium.org/1882143005/diff/1/testing/tools/run_javascript_tests.py#newcode51 testing/tools/run_javascript_tests.py:51: help='run NUM_WORKERS jobs in parallel') On 2016/04/13 17:52:43, Tom ...
4 years, 8 months ago (2016-04-13 17:56:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882143005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882143005/20001
4 years, 8 months ago (2016-04-13 17:56:29 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 18:09:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/a654f0d0889c50d0995bd873c119ae75b0ab...

Powered by Google App Engine
This is Rietveld 408576698