Chromium Code Reviews
DescriptionRevert of Added Layer based clipping to MenuScrollViewContainer::MenuScrollView (patchset #3 id:40001 of https://codereview.chromium.org/1812303002/ )
Reason for revert:
Reverting due to http://crbug.com/602913
Original issue's description:
> Added Layer based clipping to MenuScrollViewContainer::MenuScrollView
>
> ToolbarActionViews now own their own Layers so that they can host the
> material design ripple. The icons were previously clipped via the
> clipping bounds set on the Canvas passed through the OnPaint() methods.
> This clipping mechanism no longer works because the icons are painted
> to their own Layers. Thus this CL updates the MenuScrollView to perform
> Layer based clipping.
>
> BUG=596073
>
> TEST=manual
>
> Committed: https://crrev.com/4aa8a6f3be2aafda269f33e9d88a44083210b71b
> Cr-Commit-Position: refs/heads/master@{#386802}
TBR=sky@chromium.org,estade@chromium.org,varkha@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=596073
Committed: https://crrev.com/473354382769d4c53fbb1b5ed13813026bd1218c
Cr-Commit-Position: refs/heads/master@{#386974}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
||||||||||||||||||||||||||||