Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1882143004: Revert of Added Layer based clipping to MenuScrollViewContainer::MenuScrollView (Closed)

Created:
4 years, 8 months ago by bruthig
Modified:
4 years, 8 months ago
Reviewers:
varkha, sky, Evan Stade
CC:
chromium-reviews, tfarina, Evan Stade
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added Layer based clipping to MenuScrollViewContainer::MenuScrollView (patchset #3 id:40001 of https://codereview.chromium.org/1812303002/ ) Reason for revert: Reverting due to http://crbug.com/602913 Original issue's description: > Added Layer based clipping to MenuScrollViewContainer::MenuScrollView > > ToolbarActionViews now own their own Layers so that they can host the > material design ripple. The icons were previously clipped via the > clipping bounds set on the Canvas passed through the OnPaint() methods. > This clipping mechanism no longer works because the icons are painted > to their own Layers. Thus this CL updates the MenuScrollView to perform > Layer based clipping. > > BUG=596073 > > TEST=manual > > Committed: https://crrev.com/4aa8a6f3be2aafda269f33e9d88a44083210b71b > Cr-Commit-Position: refs/heads/master@{#386802} TBR=sky@chromium.org,estade@chromium.org,varkha@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=596073 Committed: https://crrev.com/473354382769d4c53fbb1b5ed13813026bd1218c Cr-Commit-Position: refs/heads/master@{#386974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M ui/views/controls/menu/menu_scroll_view_container.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/views/controls/menu/menu_scroll_view_container.cc View 6 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
bruthig
Created Revert of Added Layer based clipping to MenuScrollViewContainer::MenuScrollView
4 years, 8 months ago (2016-04-13 12:54:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882143004/1
4 years, 8 months ago (2016-04-13 12:55:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 12:55:30 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 12:58:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/473354382769d4c53fbb1b5ed13813026bd1218c
Cr-Commit-Position: refs/heads/master@{#386974}

Powered by Google App Engine
This is Rietveld 408576698