Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1882113002: Update TileImageFilter to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -40 lines) Patch
M bench/TileImageFilterBench.cpp View 1 1 chunk +3 lines, -5 lines 0 comments Download
M fuzz/FilterFuzz.cpp View 1 2 1 chunk +2 lines, -7 lines 0 comments Download
M gm/bigtileimagefilter.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/filterfastbounds.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/tileimagefilter.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M include/effects/SkTileImageFilter.h View 3 chunks +11 lines, -3 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 2 1 chunk +2 lines, -7 lines 0 comments Download
M src/effects/SkTileImageFilter.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
robertphillips
4 years, 8 months ago (2016-04-12 16:17:00 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882113002/20001
4 years, 8 months ago (2016-04-12 16:44:40 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-12 16:54:11 UTC) #8
robertphillips
ping
4 years, 8 months ago (2016-04-14 18:14:20 UTC) #9
f(malita)
lgtm
4 years, 8 months ago (2016-04-14 18:36:16 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882113002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882113002/40001
4 years, 8 months ago (2016-04-15 11:49:09 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-15 12:06:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882113002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882113002/40001
4 years, 8 months ago (2016-04-15 14:56:43 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 14:57:43 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/534c270465a9824893d5c9d6c5bacef7726cc389

Powered by Google App Engine
This is Rietveld 408576698