Move webcrypto to child/ and add support to worker_webkitplatformsupport.

Move webcrypto to child/ and add support to WebKitPlatformSupportImpl.

The current content/renderer/webcrypto implementation is really generalizable to both
renderers and workers. This commit moves content/renderer/webcrypto to
content/child/webcrypto. Additionally, it adds support in WebKitPlatformSupportImpl for WebCrypto, so both workers and renderers can use it.

BUG=349514
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255658

[jww, 2014-03-06 01:12:07]

This is a first whack at moving content/renderer/webcrypto/ to
content/child/webcrytpo, as well as adding WebCrypto support to workers.

Of note, I realized that there doesn't seem to be a real need to have separate
worker and renderer implementations of WebCrypto (unless something comes along
with threading), so I've just eliminated
content/renderer/webcrypto/webcrypto_impl.

[eroman, 2014-03-06 01:49:13]

lgtm other than header guards

https://codereview.chromium.org/188203003/diff/1/content/child/webcrypto/cryp...
File content/child/webcrypto/crypto_data.h (right):

https://codereview.chromium.org/188203003/diff/1/content/child/webcrypto/cryp...
content/child/webcrypto/crypto_data.h:5: #ifndef
CONTENT_RENDERER_WEBCRYPTO_CRYPTO_DATA_H_
Please change the header guards for all files

[jww, 2014-03-06 02:04:13]

Charlie, can you take a look at this to make sure the move of
content/renderer/webcrypto to content/child/webcrypto and the changes to
content/worker/worker_webkitplatformsupport_impl.* are okay?

https://codereview.chromium.org/188203003/diff/1/content/child/webcrypto/cryp...
File content/child/webcrypto/crypto_data.h (right):

https://codereview.chromium.org/188203003/diff/1/content/child/webcrypto/cryp...
content/child/webcrypto/crypto_data.h:5: #ifndef
CONTENT_RENDERER_WEBCRYPTO_CRYPTO_DATA_H_
On 2014/03/06 01:49:13, eroman wrote:
> Please change the header guards for all files

Yikes! Thanks.

[Charlie Reis, 2014-03-06 04:34:15]

On 2014/03/06 02:04:13, jww wrote:
> Charlie, can you take a look at this to make sure the move of
> content/renderer/webcrypto to content/child/webcrypto and the changes to
> content/worker/worker_webkitplatformsupport_impl.* are okay?

[+jam]

John's probably a better reviewer for moving a feature from renderer/ to child/.
 Seems reasonable to me if it needs to be used by multiple types of child
processes.

[jam, 2014-03-06 18:11:05]

lgtm

one comment: why not put the shared crypto code in the WebKitPlatformSupportImpl
base class instead of duplicate (the few lines) in the renderer and worker
versions?

[jww, 2014-03-06 19:02:37]

On 2014/03/06 18:11:05, jam wrote:
> lgtm
> 
> one comment: why not put the shared crypto code in the
WebKitPlatformSupportImpl
> base class instead of duplicate (the few lines) in the renderer and worker
> versions?

Good catch. Initially I was thinking that they would need slightly different
implementations, but that ended up not being the case. I've updated it so it's
now in the WebKitPlatformSupportImpl base class.

[jww, 2014-03-06 19:06:14]

The CQ bit was checked by jww@chromium.org

[jww, 2014-03-06 19:08:03]

The CQ bit was unchecked by jww@chromium.org

[jww, 2014-03-06 19:09:20]

The CQ bit was checked by jww@chromium.org

[commit-bot: I haz the power, 2014-03-06 19:15:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jww@chromium.org/188203003/40001

[commit-bot: I haz the power, 2014-03-06 19:15:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 19:15:48]

Failed to apply patch for content/content_tests.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/content_tests.gypi
  Hunk #1 succeeded at 518 (offset 1 line).
  Hunk #2 FAILED at 579.
  1 out of 2 hunks FAILED -- saving rejects to file
content/content_tests.gypi.rej

Patch:       content/content_tests.gypi
Index: content/content_tests.gypi
diff --git a/content/content_tests.gypi b/content/content_tests.gypi
index
83b3c72b7e620102bc27fb1e6aae5af2cf061cdc..4ecd95f3cc465f621e3695c9b5a270b4095bb4e6
100644
--- a/content/content_tests.gypi
+++ b/content/content_tests.gypi
@@ -517,6 +517,7 @@
         'child/power_monitor_broadcast_source_unittest.cc',
         'child/resource_dispatcher_unittest.cc',
         'child/site_isolation_policy_unittest.cc',
+        'child/webcrypto/shared_crypto_unittest.cc',
         'child/worker_task_runner_unittest.cc',
         'common/android/address_parser_unittest.cc',
         'common/cc_messages_unittest.cc',
@@ -578,7 +579,6 @@
        
'renderer/screen_orientation/screen_orientation_dispatcher_unittest.cc',
         'renderer/skia_benchmarking_extension_unittest.cc',
         'renderer/v8_value_converter_impl_unittest.cc',
-        'renderer/webcrypto/shared_crypto_unittest.cc',
         'test/image_decoder_test.cc',
         'test/image_decoder_test.h',
         'test/run_all_unittests.cc',

[jww, 2014-03-06 19:32:34]

The CQ bit was checked by jww@chromium.org

[commit-bot: I haz the power, 2014-03-06 19:40:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jww@chromium.org/188203003/60001

[commit-bot: I haz the power, 2014-03-06 20:09:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-06 20:09:55]

Try jobs failed on following builders: mac_chromium_compile_dbg

[jww, 2014-03-07 06:34:56]

The CQ bit was checked by jww@chromium.org

[commit-bot: I haz the power, 2014-03-07 06:36:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jww@chromium.org/188203003/80001

[commit-bot: I haz the power, 2014-03-07 07:02:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 07:02:12]

Try jobs failed on following builders: mac_chromium_compile_dbg

[jww, 2014-03-07 16:35:56]

The CQ bit was checked by jww@chromium.org

[commit-bot: I haz the power, 2014-03-07 16:36:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jww@chromium.org/188203003/80001

[commit-bot: I haz the power, 2014-03-07 18:00:17]

Change committed as 255658