Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1881933003: Correct cases where dartium expectations co19 had diverged from dart2js expectations that are now f… (Closed)

Created:
4 years, 8 months ago by Jacob
Modified:
4 years, 8 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Correct cases where dartium expectations co19 had diverged from dart2js expectations that are now fixed by proper handling of cross-domain Window objects. BUG= Committed: https://github.com/dart-lang/sdk/commit/7d1f499e5be084bc3bc9bd646179baff0d41d58b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/co19/co19-dartium.status View 2 chunks +3 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
Jacob
TBR
4 years, 8 months ago (2016-04-13 00:53:29 UTC) #2
Jacob
Committed patchset #1 (id:1) manually as 7d1f499e5be084bc3bc9bd646179baff0d41d58b.
4 years, 8 months ago (2016-04-13 00:53:40 UTC) #4
Alan Knight
4 years, 8 months ago (2016-04-13 16:34:06 UTC) #5
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/1881933003/diff/1/tests/co19/co19-dartium.status
File tests/co19/co19-dartium.status (right):

https://codereview.chromium.org/1881933003/diff/1/tests/co19/co19-dartium.sta...
tests/co19/co19-dartium.status:1002:
LibTest/html/IFrameElement/contentWindow_A01_t01: RuntimeError # Also fails in
dart2js as this test should not pass given current Dart semantics for cross
frame windows.
If the tests are broken you should file co19 bugs for them and put the bug
reference in the suppression.

Powered by Google App Engine
This is Rietveld 408576698