Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2038)

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 1881883002: SRGB_EXT is a valid format of texture in WebGL1.0 and ES2.0 contexts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Correct texture format parameter Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/feature_info.cc
diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc
index 24fe49f94668c10fa8adb6e0564bafde487a7ae4..d77295a7851012caa2dbfc5e67184b38a1275363 100644
--- a/gpu/command_buffer/service/feature_info.cc
+++ b/gpu/command_buffer/service/feature_info.cc
@@ -553,7 +553,11 @@ void FeatureInfo::InitializeFeatures() {
validators_.render_buffer_format.AddValue(GL_SRGB8_ALPHA8_EXT);
validators_.frame_buffer_parameter.AddValue(
GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING_EXT);
- validators_.texture_unsized_internal_format.AddValue(GL_SRGB_ALPHA_EXT);
+ if (context_type_ == CONTEXT_TYPE_WEBGL1 ||
+ context_type_ == CONTEXT_TYPE_OPENGLES2) {
Zhenyao Mo 2016/04/27 17:12:26 This should be part of the "if" condition in line
xinghua.cao 2016/04/28 09:59:27 Done.
+ validators_.texture_unsized_internal_format.AddValue(GL_SRGB_EXT);
+ validators_.texture_unsized_internal_format.AddValue(GL_SRGB_ALPHA_EXT);
+ }
}
bool enable_texture_format_bgra8888 = false;
« no previous file with comments | « no previous file | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698