Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1881863003:
OOPIF: Move SequentialFocusNavigation test to interactive_ui_tests. (Closed)
|
Created:
4 years, 8 months ago by alexmos Modified:
4 years, 8 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@interactive-tests-2-keyboard Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionOOPIF: Move SequentialFocusNavigation test to interactive_ui_tests.
The test was recently disabled due to becoming flaky. This CL
converts it to an interactive test, so that focus is not tinkered with
during the test. The prerequisite work for this was in issues 559273
and 596508.
BUG=599730
Committed: https://crrev.com/94f63b7fb807642fd3373d0ae43b14f2015c8694
Cr-Commit-Position: refs/heads/master@{#387062}
Patch Set 1 #Patch Set 2 : Rebase #
Messages
Total messages: 21 (10 generated)
The CQ bit was checked by alexmos@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881863003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
Description was changed from ========== Move SequentialFocusNavigation to interactive_ui_tests. The test was recently disabled due to becoming flaky. This CL converts it to an interactive test, so that focus is not tinkered with during the test. The prerequisite work for this was in issues 559273 and 596508. BUG=599730 ========== to ========== OOPIF: Move SequentialFocusNavigation test to interactive_ui_tests. The test was recently disabled due to becoming flaky. This CL converts it to an interactive test, so that focus is not tinkered with during the test. The prerequisite work for this was in issues 559273 and 596508. BUG=599730 ==========
alexmos@chromium.org changed reviewers: + creis@chromium.org
Charlie, can you please take a look? This is a continuation of https://codereview.chromium.org/1852903002/ and https://codereview.chromium.org/1869853002/, and just a straightforward move of the test to interactive_ui_tests. The other two tests haven't had any flakiness since they were moved, so I'm hopeful that doing this will fix this test as well.
Great! LGTM.
The CQ bit was checked by alexmos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881863003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881863003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
alexmos@chromium.org changed reviewers: + thestig@chromium.org
thestig@: can you please review chrome/ for OWNERS?
lgtm
The CQ bit was checked by creis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881863003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881863003/20001
Message was sent while issue was closed.
Description was changed from ========== OOPIF: Move SequentialFocusNavigation test to interactive_ui_tests. The test was recently disabled due to becoming flaky. This CL converts it to an interactive test, so that focus is not tinkered with during the test. The prerequisite work for this was in issues 559273 and 596508. BUG=599730 ========== to ========== OOPIF: Move SequentialFocusNavigation test to interactive_ui_tests. The test was recently disabled due to becoming flaky. This CL converts it to an interactive test, so that focus is not tinkered with during the test. The prerequisite work for this was in issues 559273 and 596508. BUG=599730 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== OOPIF: Move SequentialFocusNavigation test to interactive_ui_tests. The test was recently disabled due to becoming flaky. This CL converts it to an interactive test, so that focus is not tinkered with during the test. The prerequisite work for this was in issues 559273 and 596508. BUG=599730 ========== to ========== OOPIF: Move SequentialFocusNavigation test to interactive_ui_tests. The test was recently disabled due to becoming flaky. This CL converts it to an interactive test, so that focus is not tinkered with during the test. The prerequisite work for this was in issues 559273 and 596508. BUG=599730 Committed: https://crrev.com/94f63b7fb807642fd3373d0ae43b14f2015c8694 Cr-Commit-Position: refs/heads/master@{#387062} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/94f63b7fb807642fd3373d0ae43b14f2015c8694 Cr-Commit-Position: refs/heads/master@{#387062} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
