build/args/bots/official.desktop/blimp-engine.gn - Issue 1881823002: Support references to args files in MB.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/args/bots/official.desktop/blimp-engine.gn

Issue 1881823002: Support references to args files in MB. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mb_write_args_file

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 import("//build/args/blimp_engine.gn")

	2 is_debug = true
	brettw 2016/04/12 21:52:13 I'd expect a bot generically named and especially I'd expect a bot generically named and especially in the "official" category wouldn't be debug. I think either the name of this config or the config itself should change. Dirk Pranke 2016/04/12 21:58:33 I'm not trying to match the name of the config, I' Show quoted text On 2016/04/12 21:52:13, brettw wrote: > I'd expect a bot generically named and especially in the "official" category > wouldn't be debug. I think either the name of this config or the config itself > should change. I'm not trying to match the name of the config, I'm matching the name of the bot ("blimp-engine"). It is admittedly confusing that the builder on the official waterfall is doing debug builds but that is in fact the case. I expect they'll fix this when blimp is closer to actually shipping.
OLD	NEW

« no previous file with comments | « no previous file | tools/mb/mb.py » ('j') | tools/mb/mb.py » ('J')