Remove IFDE_Pen and IFDE_Brush.

Remove IFDE_Pen and IFDE_Brush.

This Cl removes the two interfaces and renames CFDE_SolidBrush to CFDE_Brush.
Uncalled methods are removed from both CFDE_Brush and CFDE_Pen and code
simplified to match.

BUG=pdfium:468
Committed: https://pdfium.googlesource.com/pdfium/+/a5c1323ae6a2379fb5fe3ddea4c223fccd0c41b0

[dsinclair, 2016-04-12 19:10:04]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-12 19:10:04]

PTAL.

https://codereview.chromium.org/1881803003/diff/1/xfa/fde/fde_gedevice.cpp
File xfa/fde/fde_gedevice.cpp (right):

https://codereview.chromium.org/1881803003/diff/1/xfa/fde/fde_gedevice.cpp#ne...
xfa/fde/fde_gedevice.cpp:328: graphState.m_LineCap =
CFX_GraphStateData::LineCapButt;
We never called the setter methods on the pen, so I just substituted the default
values in here and removed the values from pen.

[Tom Sepez, 2016-04-12 20:03:34]

lgtm

https://codereview.chromium.org/1881803003/diff/1/xfa/fde/tto/fde_textout.cpp
File xfa/fde/tto/fde_textout.cpp (right):

https://codereview.chromium.org/1881803003/diff/1/xfa/fde/tto/fde_textout.cpp...
xfa/fde/tto/fde_textout.cpp:976: if (pBrush)
nit: no need to test, just delete.

[dsinclair, 2016-04-12 20:07:29]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-04-12 20:07:29]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1881803003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-04-12 20:07:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881803003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881803003/20001

[dsinclair, 2016-04-12 20:08:32]

https://codereview.chromium.org/1881803003/diff/1/xfa/fde/tto/fde_textout.cpp
File xfa/fde/tto/fde_textout.cpp (right):

https://codereview.chromium.org/1881803003/diff/1/xfa/fde/tto/fde_textout.cpp...
xfa/fde/tto/fde_textout.cpp:976: if (pBrush)
On 2016/04/12 20:03:34, Tom Sepez wrote:
> nit: no need to test, just delete.

Done.

[commit-bot: I haz the power, 2016-04-12 20:19:41]

Description was changed from

==========
Remove IFDE_Pen and IFDE_Brush.

This Cl removes the two interfaces and renames CFDE_SolidBrush to CFDE_Brush.
Uncalled methods are removed from both CFDE_Brush and CFDE_Pen and code
simplified to match.

BUG=pdfium:468
==========

to

==========
Remove IFDE_Pen and IFDE_Brush.

This Cl removes the two interfaces and renames CFDE_SolidBrush to CFDE_Brush.
Uncalled methods are removed from both CFDE_Brush and CFDE_Pen and code
simplified to match.

BUG=pdfium:468

Committed:
https://pdfium.googlesource.com/pdfium/+/a5c1323ae6a2379fb5fe3ddea4c223fccd0c...
==========

[commit-bot: I haz the power, 2016-04-12 20:19:42]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/a5c1323ae6a2379fb5fe3ddea4c223fccd0c...