Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1881783002: Mac h264: Remove CFRetainCount assertion (Closed)

Created:
4 years, 8 months ago by ccameron
Modified:
4 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac h264: Remove CFRetainCount assertion The CVPixelBuffers have an arbitrarily long lifetime now (they are to be handed to an AVSampleBufferDisplayLayer). It will not guaranteed that they are will be released by this call. BUG=600685 Committed: https://crrev.com/2d474e5aa58b32a51f7e4e3ec91e915c6657cfd1 Cr-Commit-Position: refs/heads/master@{#386572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/common/gpu/media/vt_video_decode_accelerator_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
ccameron
Does this seem reasonable to you?
4 years, 8 months ago (2016-04-12 00:44:21 UTC) #2
sandersd (OOO until July 31)
lgtm. I did like having these when the code was new, but this one is ...
4 years, 8 months ago (2016-04-12 00:50:05 UTC) #3
ccameron
Thanks!
4 years, 8 months ago (2016-04-12 00:54:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881783002/1
4 years, 8 months ago (2016-04-12 00:55:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 03:40:16 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 03:42:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d474e5aa58b32a51f7e4e3ec91e915c6657cfd1
Cr-Commit-Position: refs/heads/master@{#386572}

Powered by Google App Engine
This is Rietveld 408576698