Add deep equivalence test for Send/NewStructures.

Add deep equivalence test for Send/NewStructures.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/058441e1fa7a0da43072f48e86ee8718d6202e38

[Johnni Winther, 2016-04-12 14:03:04]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-04-12 17:33:43]

lgtm

https://codereview.chromium.org/1881743004/diff/1/pkg/compiler/lib/src/serial...
File pkg/compiler/lib/src/serialization/equivalence.dart (right):

https://codereview.chromium.org/1881743004/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/equivalence.dart:217: return
areTypesEquivalent(structure1.type, structure1.type);
consider combining similar cases. No need to add common base-types to combine
them, though - since this code is mainly for tests and assertions we can just
use dynamic :)

var ad = a;
var bd = b;

switch (a.kind) {
  case SendStructureKind.IS:
  case SendStructureKind.IS_NOT:
  case SendStructureKind.AS:
    return areTypesEquivalent(ad.type, bd.type);

  case SendStructureKind.INVOKE:
  case SendStructureKind.INCOMPATIBLE_INVOKE:
    if (!areSelectorsEquivalent(ad.selector, bd.selector)) return false;
    continue semantics;

  case SendStructureKind.UNARY:
  case SendStructureKind.INDEX_PREFIX:
    if (!areSelectorsEquivalent(ad.operator, bd.operator)) return false;
    continue semantics;

  semantics:
  case SendStructureKind.GET:
  case SendStructureKind.SET:
  case SendStructureKind.INDEX:
  case SendStructureKind.EQUALS:
  case SendStructureKind.NOT_EQUALS:
  case SendStructureKind.BINARY:
  case SendStructureKind.INDEX_SET:
    return areAccessSemanticsEquivalent(ad.semantics, bd.semantics);

...

[Johnni Winther, 2016-04-13 07:59:11]

https://codereview.chromium.org/1881743004/diff/1/pkg/compiler/lib/src/serial...
File pkg/compiler/lib/src/serialization/equivalence.dart (right):

https://codereview.chromium.org/1881743004/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/equivalence.dart:217: return
areTypesEquivalent(structure1.type, structure1.type);
On 2016/04/12 17:33:42, Siggi Cherem (dart-lang) wrote:
> consider combining similar cases. No need to add common base-types to combine
> them, though - since this code is mainly for tests and assertions we can just
> use dynamic :)
> 
> var ad = a;
> var bd = b;
> 
> switch (a.kind) {
>   case SendStructureKind.IS:
>   case SendStructureKind.IS_NOT:
>   case SendStructureKind.AS:
>     return areTypesEquivalent(ad.type, bd.type);
> 
>   case SendStructureKind.INVOKE:
>   case SendStructureKind.INCOMPATIBLE_INVOKE:
>     if (!areSelectorsEquivalent(ad.selector, bd.selector)) return false;
>     continue semantics;
> 
>   case SendStructureKind.UNARY:
>   case SendStructureKind.INDEX_PREFIX:
>     if (!areSelectorsEquivalent(ad.operator, bd.operator)) return false;
>     continue semantics;
> 
>   semantics:
>   case SendStructureKind.GET:
>   case SendStructureKind.SET:
>   case SendStructureKind.INDEX:
>   case SendStructureKind.EQUALS:
>   case SendStructureKind.NOT_EQUALS:
>   case SendStructureKind.BINARY:
>   case SendStructureKind.INDEX_SET:
>     return areAccessSemanticsEquivalent(ad.semantics, bd.semantics);
> 
> ...

Done.

[Johnni Winther, 2016-04-13 08:10:06]

Description was changed from

==========
Add deep equivalence test for Send/NewStructures.
==========

to

==========
Add deep equivalence test for Send/NewStructures.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/058441e1fa7a0da43072f48e86ee8718d6202e38
==========

[Johnni Winther, 2016-04-13 08:10:08]

Committed patchset #2 (id:20001) manually as
058441e1fa7a0da43072f48e86ee8718d6202e38 (presubmit successful).