Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 188163003: Bluetooth: register agent when we have an adapter (Closed)

Created:
6 years, 9 months ago by keybuk
Modified:
6 years, 9 months ago
Reviewers:
armansito
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Bluetooth: register agent when we have an adapter Registering the agent on creation of the adapter object can result in a race condition where the Bluetooth Daemon isn't running to respond to the method call yet. Move the registration to the SetAdapter() call, this covers both the Bluetooth Daemon actually being running on initial startup and the case where the daemon restarts. BUG=346975 TEST=restart bluetoothd; verify agent re-registered Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -21 lines) Patch
device/bluetooth/bluetooth_adapter_chromeos.h View 1 chunk +0 lines, -3 lines 0 comments Download
device/bluetooth/bluetooth_adapter_chromeos.cc View 5 chunks +24 lines, -18 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
keybuk
6 years, 9 months ago (2014-03-06 18:37:07 UTC) #1
armansito
lgtm. I saw that https://codereview.chromium.org/177703006/ addresses the crash case.
6 years, 9 months ago (2014-03-07 00:20:02 UTC) #2
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 9 months ago (2014-03-07 00:53:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/188163003/1
6 years, 9 months ago (2014-03-07 01:00:56 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 03:52:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 03:52:29 UTC) #6
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 9 months ago (2014-03-07 04:09:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/188163003/1
6 years, 9 months ago (2014-03-07 04:14:34 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 06:01:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 06:01:23 UTC) #10
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 9 months ago (2014-03-07 06:51:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/188163003/1
6 years, 9 months ago (2014-03-07 06:54:04 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 09:42:37 UTC) #13
Message was sent while issue was closed.
Change committed as 255571

Powered by Google App Engine
This is Rietveld 408576698