third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasRenderingContextFactory.h - Issue 1881563003: Implement OffscreenCanvas.getContext('webgl')

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasRenderingContextFactory.h

Issue 1881563003: Implement OffscreenCanvas.getContext('webgl') (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: offscreenCanvas.getContext('webgl') crashes on worker Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasRenderingContext.h ('K') | « third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasRenderingContext.h ('k') | third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h » ('j') | third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasRenderingContextFactory.h

diff --git a/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasRenderingContextFactory.h b/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasRenderingContextFactory.h

index 3dd34985d7341518706565bd68ccfa74771e709b..a13ce4e12cb869a1ff13b65e2f830b6b0bac3877 100644

--- a/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasRenderingContextFactory.h

+++ b/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasRenderingContextFactory.h

@@ -5,6 +5,7 @@

#ifndef OffscreenCanvasRenderingContextFactory_h

#define OffscreenCanvasRenderingContextFactory_h

+#include "bindings/core/v8/ScriptState.h"

#include "wtf/Allocator.h"

#include "wtf/PassRefPtr.h"

@@ -21,7 +22,7 @@ public:

OffscreenCanvasRenderingContextFactory() = default;

virtual ~OffscreenCanvasRenderingContextFactory() { }

- virtual OffscreenCanvasRenderingContext* create(OffscreenCanvas*, const CanvasContextCreationAttributes&) = 0;

+ virtual OffscreenCanvasRenderingContext* create(ScriptState*, OffscreenCanvas*, const CanvasContextCreationAttributes&) = 0;

virtual OffscreenCanvasRenderingContext::ContextType getContextType() const = 0;

virtual void onError(OffscreenCanvas*, const String& error) = 0;

};