third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.h - Issue 1881563003: Implement OffscreenCanvas.getContext('webgl')

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.h

Issue 1881563003: Implement OffscreenCanvas.getContext('webgl') (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: offscreenCanvas.getContext('webgl') crashes on worker Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D-in-worker.html ('K') | « third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.h ('k') | third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.cpp » ('j') | third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.h

diff --git a/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.h b/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.h

index 3b285c6d5c391d61862fcdcd8d0661fe386bc7d5..9c185e8d9ad878d8e1799cfb0c9c6bf61b0c2e60 100644

--- a/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.h

+++ b/third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.h

@@ -20,6 +20,8 @@ class ImageBitmap;

class OffscreenCanvasRenderingContext;

class OffscreenCanvasRenderingContext2D;

class OffscreenCanvasRenderingContextFactory;

+class OffscreenCanvasRenderingContext2DOrWebGLRenderingContextOrWebGL2RenderingContext;

+typedef OffscreenCanvasRenderingContext2DOrWebGLRenderingContextOrWebGL2RenderingContext OffscreenRenderingContext;

class MODULES_EXPORT OffscreenCanvas final : public GarbageCollectedFinalized<OffscreenCanvas>, public ScriptWrappable {

DEFINE_WRAPPERTYPEINFO();

@@ -34,11 +36,11 @@ public:

void setHeight(unsigned);

// API Methods

- OffscreenCanvasRenderingContext2D* getContext(const String&, const CanvasContextCreationAttributes&);

+ void getContext(ScriptState*, const String&, const CanvasContextCreationAttributes&, OffscreenRenderingContext&);

ImageBitmap* transferToImageBitmap(ExceptionState&);

IntSize size() const { return m_size; }

- OffscreenCanvasRenderingContext2D* renderingContext() const;

+ OffscreenCanvasRenderingContext* renderingContext() const;

void setAssociatedCanvas(HTMLCanvasElement* canvas) { m_canvas = canvas; }

HTMLCanvasElement* getAssociatedCanvas() const { return m_canvas; }