third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h - Issue 1881563003: Implement OffscreenCanvas.getContext('webgl')

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

Issue 1881563003: Implement OffscreenCanvas.getContext('webgl') (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and remove static_cast Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasModules.idl ('k') | third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

diff --git a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

index f217cdf05945f1c3155e7db62db4fb548219f88a..1db409c741ce1a55017507de1e6ac80c65c8c474 100644

--- a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

+++ b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

@@ -12,8 +12,6 @@

namespace blink {

-class HTMLCanvasElement;

class MODULES_EXPORT OffscreenCanvasRenderingContext2D final : public CanvasRenderingContext, public BaseRenderingContext2D {

DEFINE_WRAPPERTYPEINFO();

USING_GARBAGE_COLLECTED_MIXIN(OffscreenCanvasRenderingContext2D);

@@ -23,7 +21,7 @@ public:

Factory() {}

~Factory() override {}

- CanvasRenderingContext* create(OffscreenCanvas* canvas, const CanvasContextCreationAttributes& attrs) override

+ CanvasRenderingContext* create(ScriptState* scriptState, OffscreenCanvas* canvas, const CanvasContextCreationAttributes& attrs) override

{

return new OffscreenCanvasRenderingContext2D(canvas, attrs);

}

@@ -38,6 +36,7 @@ public:

~OffscreenCanvasRenderingContext2D() override;

ContextType getContextType() const override { return Context2d; }

bool is2d() const override { return true; }

+ void setOffscreenCanvasGetContextResult(OffscreenRenderingContext&) final;

void setIsHidden(bool) final { ASSERT_NOT_REACHED(); }

void stop() final { ASSERT_NOT_REACHED(); }

void setCanvasGetContextResult(RenderingContext&) final {}