third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp - Issue 1881563003: Implement OffscreenCanvas.getContext('webgl')

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp

Issue 1881563003: Implement OffscreenCanvas.getContext('webgl') (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and remove static_cast Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h ('k') | third_party/WebKit/Source/modules/ModulesInitializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp

diff --git a/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp b/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp

index 771219507b7f2ebed8f314f7ed7f67cd9ab77a24..b29be4df2562f67099e7aa9968280a82a549d3fe 100644

--- a/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp

+++ b/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp

@@ -58,7 +58,7 @@ ImageBitmap* OffscreenCanvas::transferToImageBitmap(ExceptionState& exceptionSta

return image;

}

-CanvasRenderingContext* OffscreenCanvas::getCanvasRenderingContext(const String& id, const CanvasContextCreationAttributes& attributes)

+CanvasRenderingContext* OffscreenCanvas::getCanvasRenderingContext(ScriptState* scriptState, const String& id, const CanvasContextCreationAttributes& attributes)

{

CanvasRenderingContext::ContextType contextType = CanvasRenderingContext::contextTypeFromId(id);

@@ -76,7 +76,7 @@ CanvasRenderingContext* OffscreenCanvas::getCanvasRenderingContext(const String&

return nullptr;

}

} else {

- m_context = factory->create(this, attributes);

+ m_context = factory->create(scriptState, this, attributes);

}

return m_context.get();