third_party/WebKit/Source/core/html/canvas/CanvasRenderingContextFactory.h - Issue 1881563003: Implement OffscreenCanvas.getContext('webgl')

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContextFactory.h

Issue 1881563003: Implement OffscreenCanvas.getContext('webgl') (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and remove static_cast Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp ('k') | third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContextFactory.h

diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContextFactory.h b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContextFactory.h

index a1d94d3b90220dc542a4ece131ee65bb21790b8b..a8d3f9a59acc36315b33079da870d1e64c3213c2 100644

--- a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContextFactory.h

+++ b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContextFactory.h

@@ -25,7 +25,7 @@ public:

virtual ~CanvasRenderingContextFactory() { }

virtual CanvasRenderingContext* create(HTMLCanvasElement*, const CanvasContextCreationAttributes&, Document&) { return nullptr; }

- virtual CanvasRenderingContext* create(OffscreenCanvas*, const CanvasContextCreationAttributes&) { return nullptr; }

+ virtual CanvasRenderingContext* create(ScriptState*, OffscreenCanvas*, const CanvasContextCreationAttributes&) { return nullptr; }

virtual CanvasRenderingContext::ContextType getContextType() const = 0;

virtual void onError(HTMLCanvasElement*, const String& error) {};

virtual void onError(OffscreenCanvas*, const String& error) {};