third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h - Issue 1881563003: Implement OffscreenCanvas.getContext('webgl')

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

Issue 1881563003: Implement OffscreenCanvas.getContext('webgl') (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase and remove static_cast Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-getContext2D-in-worker-expected.txt ('k') | third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

index 88d3e5347bf0f7dddedae3368b41832ef8b1e2c6..315aebe2986aed5ffb94ea6f770e6b60ae623c77 100644

--- a/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

+++ b/third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h

@@ -73,7 +73,8 @@ public:

virtual bool hasAlpha() const { return true; }

virtual void setIsHidden(bool) = 0;

virtual bool isContextLost() const { return true; }

- virtual void setCanvasGetContextResult(RenderingContext&) = 0;

+ virtual void setCanvasGetContextResult(RenderingContext&) { ASSERT_NOT_REACHED(); };

+ virtual void setOffscreenCanvasGetContextResult(OffscreenRenderingContext&) { ASSERT_NOT_REACHED(); }

// Return true if the content is updated.

virtual bool paintRenderingResultsToCanvas(SourceDrawingBuffer) { return false; }

@@ -126,8 +127,7 @@ public:

virtual ImageBitmap* transferToImageBitmap(ExceptionState&) { return nullptr; }

protected:

- CanvasRenderingContext(HTMLCanvasElement*);

- CanvasRenderingContext(OffscreenCanvas*);

+ CanvasRenderingContext(HTMLCanvasElement* = nullptr, OffscreenCanvas* = nullptr);

DECLARE_VIRTUAL_TRACE();

virtual void stop() = 0;