Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Side by Side Diff: sdk/lib/convert/line_splitter.dart

Issue 1881553002: Revert "Steps towards making the convert library strong-mode compliant." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sdk/lib/convert/latin1.dart ('k') | sdk/lib/convert/utf.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart.convert; 5 part of dart.convert;
6 6
7 // Character constants. 7 // Character constants.
8 const int _LF = 10; 8 const int _LF = 10;
9 const int _CR = 13; 9 const int _CR = 13;
10 10
11 /** 11 /**
12 * A [Converter] that splits a [String] into individual lines. 12 * A [Converter] that splits a [String] into individual lines.
13 * 13 *
14 * A line is terminated by either a CR (U+000D), a LF (U+000A), a 14 * A line is terminated by either a CR (U+000D), a LF (U+000A), a
15 * CR+LF sequence (DOS line ending), 15 * CR+LF sequence (DOS line ending),
16 * and a final non-empty line can be ended by the end of the string. 16 * and a final non-empty line can be ended by the end of the string.
17 * 17 *
18 * The returned lines do not contain the line terminators. 18 * The returned lines do not contain the line terminators.
19 */ 19 */
20 class LineSplitter extends 20 class LineSplitter extends Converter<String, List<String>> {
21 ChunkedConverter<String, List<String>, String, String> {
22 21
23 const LineSplitter(); 22 const LineSplitter();
24 23
25 /// Split [lines] into individual lines. 24 /// Split [lines] into individual lines.
26 /// 25 ///
27 /// If [start] and [end] are provided, only split the contents of 26 /// If [start] and [end] are provided, only split the contents of
28 /// `lines.substring(start, end)`. The [start] and [end] values must 27 /// `lines.substring(start, end)`. The [start] and [end] values must
29 /// specify a valid sub-range of [lines] 28 /// specify a valid sub-range of [lines]
30 /// (`0 <= start <= end <= lines.length`). 29 /// (`0 <= start <= end <= lines.length`).
31 static Iterable<String> split(String lines, [int start = 0, int end]) sync* { 30 static Iterable<String> split(String lines, [int start = 0, int end]) sync* {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 } 72 }
74 return lines; 73 return lines;
75 } 74 }
76 75
77 StringConversionSink startChunkedConversion(Sink<String> sink) { 76 StringConversionSink startChunkedConversion(Sink<String> sink) {
78 if (sink is! StringConversionSink) { 77 if (sink is! StringConversionSink) {
79 sink = new StringConversionSink.from(sink); 78 sink = new StringConversionSink.from(sink);
80 } 79 }
81 return new _LineSplitterSink(sink); 80 return new _LineSplitterSink(sink);
82 } 81 }
82
83 // Override the base-class' bind, to provide a better type.
84 Stream<String> bind(Stream<String> stream) => super.bind(stream);
83 } 85 }
84 86
85 // TODO(floitsch): deal with utf8. 87 // TODO(floitsch): deal with utf8.
86 class _LineSplitterSink extends StringConversionSinkBase { 88 class _LineSplitterSink extends StringConversionSinkBase {
87 final StringConversionSink _sink; 89 final StringConversionSink _sink;
88 90
89 /// The carry-over from the previous chunk. 91 /// The carry-over from the previous chunk.
90 /// 92 ///
91 /// If the previous slice ended in a line without a line terminator, 93 /// If the previous slice ended in a line without a line terminator,
92 /// then the next slice may continue the line. 94 /// then the next slice may continue the line.
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 _sink.add(lines.substring(sliceStart, i)); 152 _sink.add(lines.substring(sliceStart, i));
151 sliceStart = i + 1; 153 sliceStart = i + 1;
152 } 154 }
153 if (sliceStart < end) { 155 if (sliceStart < end) {
154 _carry = lines.substring(sliceStart, end); 156 _carry = lines.substring(sliceStart, end);
155 } else { 157 } else {
156 _skipLeadingLF = (char == _CR); 158 _skipLeadingLF = (char == _CR);
157 } 159 }
158 } 160 }
159 } 161 }
OLDNEW
« no previous file with comments | « sdk/lib/convert/latin1.dart ('k') | sdk/lib/convert/utf.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698