net/test/embedded_test_server/embedded_test_server_connection_listener.h - Issue 1881463003: Add a browsertest suite for net predictor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/embedded_test_server/embedded_test_server_connection_listener.h

Issue 1881463003: Add a browsertest suite for net predictor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: EXPECT that we get the right number of accepted connections after waiting Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/test/embedded_test_server/embedded_test_server.cc ('k') | net/test/embedded_test_server/embedded_test_server_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/test/embedded_test_server/embedded_test_server_connection_listener.h

diff --git a/net/test/embedded_test_server/embedded_test_server_connection_listener.h b/net/test/embedded_test_server/embedded_test_server_connection_listener.h

index 01d5415220deb5866c2431b000b796c1503506b1..d712aea49476b40c3fea7e63fa1ba725caa203fb 100644

--- a/net/test/embedded_test_server/embedded_test_server_connection_listener.h

+++ b/net/test/embedded_test_server/embedded_test_server_connection_listener.h

@@ -18,7 +18,7 @@ class EmbeddedTestServerConnectionListener {

virtual void AcceptedSocket(const StreamSocket& socket) = 0;

// Notified when a socket was read from by the EmbeddedTestServer.

- virtual void ReadFromSocket(const StreamSocket& socket) = 0;

+ virtual void ReadFromSocket(const StreamSocket& socket, int rv) = 0;

protected:

EmbeddedTestServerConnectionListener() {}