net/test/embedded_test_server/embedded_test_server.cc - Issue 1881463003: Add a browsertest suite for net predictor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/embedded_test_server/embedded_test_server.cc

Issue 1881463003: Add a browsertest suite for net predictor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactor, disable preconnect + intercept request for determinism Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/test/embedded_test_server/embedded_test_server.cc

diff --git a/net/test/embedded_test_server/embedded_test_server.cc b/net/test/embedded_test_server/embedded_test_server.cc

index 152d46020691d3398d569b1ae219657ca883e145..1d03c9f7c8f470b2677aa8dce878eddd60936b65 100644

--- a/net/test/embedded_test_server/embedded_test_server.cc

+++ b/net/test/embedded_test_server/embedded_test_server.cc

@@ -376,7 +376,7 @@ void EmbeddedTestServer::OnReadCompleted(HttpConnection* connection, int rv) {

bool EmbeddedTestServer::HandleReadResult(HttpConnection* connection, int rv) {

DCHECK(io_thread_->task_runner()->BelongsToCurrentThread());

if (connection_listener_)

- connection_listener_->ReadFromSocket(*connection->socket_);

+ connection_listener_->ReadFromSocket(*connection->socket_, rv);

if (rv <= 0) {

DidClose(connection);

return false;