Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1881423004:
Fix crash in PPB_Graphics3D_Impl destructor. (Closed)
|
Created:
4 years, 8 months ago by danakj Modified:
4 years, 8 months ago CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, Ken Russell (switch to Gerrit) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix crash in PPB_Graphics3D_Impl destructor.
If init fails, the command_buffer_ is null.
R=piman,sievers
BUG=602948, 584497
Committed: https://crrev.com/04ae47df06cb5bfebb7e05b5f11c0b7f3fbb57b8
Cr-Commit-Position: refs/heads/master@{#387064}
Patch Set 1 #Patch Set 2 : pepper: comment #Messages
Total messages: 18 (9 generated)
Description was changed from ========== Fix crash in PPB_Graphics3D_Impl destructor. If init fails, the command_buffer_ is null. R=piman BUG=602948 ========== to ========== Fix crash in PPB_Graphics3D_Impl destructor. If init fails, the command_buffer_ is null. R=piman BUG=602948, 584497 ==========
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881423004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881423004/1
Though, the PPB_Graphics3D_Impl owns the command_buffer_ (unlike the GLES2Implementation case), so I'm not sure we have to unset the client anyway, the GpuControl will be destroyed before |this|.
On 2016/04/13 18:24:11, danakj wrote: > Though, the PPB_Graphics3D_Impl owns the command_buffer_ (unlike the > GLES2Implementation case), so I'm not sure we have to unset the client anyway, > the GpuControl will be destroyed before |this|. Oh, the comment on the original CL was "the WeakPtr factory invalidates before the command_buffer_ is destroyed" so we're matching that.
lgtm
The CQ bit was checked by danakj@chromium.org
The CQ bit was unchecked by danakj@chromium.org
Description was changed from ========== Fix crash in PPB_Graphics3D_Impl destructor. If init fails, the command_buffer_ is null. R=piman BUG=602948, 584497 ========== to ========== Fix crash in PPB_Graphics3D_Impl destructor. If init fails, the command_buffer_ is null. NOTRY=true R=piman,sievers BUG=602948, 584497 ==========
Description was changed from ========== Fix crash in PPB_Graphics3D_Impl destructor. If init fails, the command_buffer_ is null. NOTRY=true R=piman,sievers BUG=602948, 584497 ========== to ========== Fix crash in PPB_Graphics3D_Impl destructor. If init fails, the command_buffer_ is null. R=piman,sievers BUG=602948, 584497 ==========
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881423004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881423004/20001
Message was sent while issue was closed.
Description was changed from ========== Fix crash in PPB_Graphics3D_Impl destructor. If init fails, the command_buffer_ is null. R=piman,sievers BUG=602948, 584497 ========== to ========== Fix crash in PPB_Graphics3D_Impl destructor. If init fails, the command_buffer_ is null. R=piman,sievers BUG=602948, 584497 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
Description was changed from ========== Fix crash in PPB_Graphics3D_Impl destructor. If init fails, the command_buffer_ is null. R=piman,sievers BUG=602948, 584497 ========== to ========== Fix crash in PPB_Graphics3D_Impl destructor. If init fails, the command_buffer_ is null. R=piman,sievers BUG=602948, 584497 Committed: https://crrev.com/04ae47df06cb5bfebb7e05b5f11c0b7f3fbb57b8 Cr-Commit-Position: refs/heads/master@{#387064} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/04ae47df06cb5bfebb7e05b5f11c0b7f3fbb57b8 Cr-Commit-Position: refs/heads/master@{#387064} |
