Adjust bytecode operand values for big endian.

Adjust bytecode operand values for big endian.

Operand values in Bytecodes.DecodeBytecodeAndOperands test are encoded
in little endian format. The test calls Bytecodes::Decode function which
reads the operands but the values are byte swapped on big endian
machines. Added big endian encoded data which decodes correctly on BE
machines.

BUG=

Committed: https://crrev.com/3b416c67f5c5294ffb937110478baf6048c0c39a
Cr-Commit-Position: refs/heads/master@{#35447}

[miran.karic, 2016-04-13 09:08:07]

miran.karic@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, balazs.kilvady@imgtec.com,
ivica.bogosavljevic@imgtec.com, oth@chromium.org

[oth, 2016-04-13 10:18:11]

LGTM with a minor comment.

Thanks for fixing this.

https://codereview.chromium.org/1881423002/diff/1/test/unittests/interpreter/...
File test/unittests/interpreter/bytecodes-unittest.cc (right):

https://codereview.chromium.org/1881423002/diff/1/test/unittests/interpreter/...
test/unittests/interpreter/bytecodes-unittest.cc:222: #else
For consistency with similar endian paths, can this explicitly check for
V8_TARGET_LITTLE_ENDIAN here and have a trailer like:

"#else
#error Unknown byte ordering
#endif"

Thanks

[miran.karic, 2016-04-13 10:40:15]

https://codereview.chromium.org/1881423002/diff/1/test/unittests/interpreter/...
File test/unittests/interpreter/bytecodes-unittest.cc (right):

https://codereview.chromium.org/1881423002/diff/1/test/unittests/interpreter/...
test/unittests/interpreter/bytecodes-unittest.cc:222: #else
On 2016/04/13 10:18:11, oth wrote:
> For consistency with similar endian paths, can this explicitly check for
> V8_TARGET_LITTLE_ENDIAN here and have a trailer like:
> 
> "#else
> #error Unknown byte ordering
> #endif"
> 
> Thanks

Done.

[miran.karic, 2016-04-13 13:13:20]

The CQ bit was checked by miran.karic@imgtec.com

[miran.karic, 2016-04-13 13:13:20]

The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org
Link to the patchset: https://codereview.chromium.org/1881423002/#ps40001
(title: "Swap BE and LE data")

[commit-bot: I haz the power, 2016-04-13 13:13:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881423002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881423002/40001

[commit-bot: I haz the power, 2016-04-13 13:52:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-13 13:53:12]

Description was changed from

==========
Adjust bytecode operand values for big endian.

Operand values in Bytecodes.DecodeBytecodeAndOperands test are encoded
in little endian format. The test calls Bytecodes::Decode function which
reads the operands but the values are byte swapped on big endian
machines. Added big endian encoded data which decodes correctly on BE
machines.

BUG=
==========

to

==========
Adjust bytecode operand values for big endian.

Operand values in Bytecodes.DecodeBytecodeAndOperands test are encoded
in little endian format. The test calls Bytecodes::Decode function which
reads the operands but the values are byte swapped on big endian
machines. Added big endian encoded data which decodes correctly on BE
machines.

BUG=

Committed: https://crrev.com/3b416c67f5c5294ffb937110478baf6048c0c39a
Cr-Commit-Position: refs/heads/master@{#35447}
==========

[commit-bot: I haz the power, 2016-04-13 13:53:13]

Patchset 3 (id:??) landed as
https://crrev.com/3b416c67f5c5294ffb937110478baf6048c0c39a
Cr-Commit-Position: refs/heads/master@{#35447}