Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 1881413002: [turbofan] Use StringAddStub if either input to JSAdd is a string. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use StringAddStub if either input to JSAdd is a string. The StringAddStub can automatically convert arbitrary inputs according to the semantics for the addition operator, if one side is already a string. R=jarin@chromium.org Committed: https://crrev.com/84c329e22e7a2ab42f89363a7d37d6cf3cffdc13 Cr-Commit-Position: refs/heads/master@{#35429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-13 07:26:43 UTC) #1
Benedikt Meurer
Hey Jaro, Another easy one for splay. Please take a look. Thanks, Benedikt
4 years, 8 months ago (2016-04-13 07:27:06 UTC) #2
Jarin
lgtm
4 years, 8 months ago (2016-04-13 07:31:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881413002/1
4 years, 8 months ago (2016-04-13 07:33:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 08:03:17 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 08:04:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84c329e22e7a2ab42f89363a7d37d6cf3cffdc13
Cr-Commit-Position: refs/heads/master@{#35429}

Powered by Google App Engine
This is Rietveld 408576698