Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1881383005: [alerts-dispatcher] switch to OptionalLogin (Closed)

Created:
4 years, 8 months ago by seanmccullough1
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M go/src/infra/monitoring/dispatcher/dispatcher.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
seanmccullough1
4 years, 8 months ago (2016-04-14 00:07:01 UTC) #3
Vadim Sh.
lgtm to reiterate: instead of failing when it can't find creds or they are insufficient, ...
4 years, 8 months ago (2016-04-14 00:10:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881383005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881383005/1
4 years, 8 months ago (2016-04-14 00:36:32 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 00:42:36 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/cd9cb0b84764003f3a2312ecd4dc8...

Powered by Google App Engine
This is Rietveld 408576698