Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1881383004: Do not trigger background compilation while top level parsing in mutator thread (Closed)

Created:
4 years, 8 months ago by srdjan
Modified:
4 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not trigger background compilation while top level parsing in mutator thread BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/898aa67b430efa9da1dba1010d3146409666ea86

Patch Set 1 #

Patch Set 2 : c #

Patch Set 3 : c #

Patch Set 4 : d #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M runtime/vm/compiler.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
srdjan
4 years, 8 months ago (2016-04-13 23:24:03 UTC) #2
siva
lgtm
4 years, 8 months ago (2016-04-14 00:00:32 UTC) #3
srdjan
4 years, 8 months ago (2016-04-14 02:42:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
898aa67b430efa9da1dba1010d3146409666ea86 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698