Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1881383003: [Atomics] code stubs for atomic operations (Closed)

Created:
4 years, 8 months ago by binji
Modified:
4 years, 8 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Atomics] code stubs for atomic operations Reland of (https://codereview.chromium.org/1617503003) * New atomic code stubs for x64, ia32, arm, arm64 * Add convenience functions JumpIfNotValidSmiValue, JumpIfUintNotValidSmiValue to macro-assembler-ia32 (API based on x64 macro assembler) * Remove runtime implementation of Atomics.load, the code stub should always be called instead * Add new test to mjsunit atomics test; check that Smi values of different sizes are supported when possible, else fall back to HeapNumbers These changes were needed to add another codestub: * Bump kStubMajorKeyBits from 7 to 8 * Reduce ScriptContextFieldStub::kSlotIndexBits from 13 to 12 BUG=v8:4614 LOG=y TBR=jarin@chromium.org,bmeurer@chromium.org,rodolph.perfetta@gmail.com,machenbach@chromium.org Review URL: https://codereview.chromium.org/1617503003 Cr-Commit-Position: refs/heads/master@{#35427} Committed: https://crrev.com/5e9ddf6ce4b698cb3112bd349ca5206cfada1437 Cr-Commit-Position: refs/heads/master@{#35453}

Patch Set 1 #

Patch Set 2 : fix unused function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+980 lines, -103 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +160 lines, -0 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +138 lines, -0 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/builtins.h View 2 chunks +16 lines, -13 lines 0 comments Download
M src/builtins.cc View 1 chunk +137 lines, -0 lines 0 comments Download
M src/code-factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +169 lines, -0 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +17 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/js/harmony-atomics.js View 3 chunks +4 lines, -13 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +12 lines, -11 lines 0 comments Download
M src/runtime/runtime-atomics.cc View 1 5 chunks +23 lines, -46 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +163 lines, -0 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/atomics.js View 4 chunks +34 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881383003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881383003/20001
4 years, 8 months ago (2016-04-13 18:19:35 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 18:21:35 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 18:24:36 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5e9ddf6ce4b698cb3112bd349ca5206cfada1437
Cr-Commit-Position: refs/heads/master@{#35453}

Powered by Google App Engine
This is Rietveld 408576698