Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: components/safe_browsing_db/database_manager.cc

Issue 1881353002: SafeBrowsing: Adds response handler for API blacklist check in Database Manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@osb-impl-1
Patch Set: Review Comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/database_manager.cc
diff --git a/components/safe_browsing_db/database_manager.cc b/components/safe_browsing_db/database_manager.cc
index c8d7aa30afa2ae750bd85757b4927043b5e5bae0..218e8e038c8e3f0f139a4931d53ab2d51c490b97 100644
--- a/components/safe_browsing_db/database_manager.cc
+++ b/components/safe_browsing_db/database_manager.cc
@@ -86,7 +86,24 @@ void SafeBrowsingDatabaseManager::HandleGetHashesWithApisResults(
const std::vector<SBFullHashResult>& full_hash_results,
const base::TimeDelta& negative_cache_duration) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
- // TODO(kcarattini): Implement response handler.
+ DCHECK(check);
+
+ ThreatMetadata md;
+ // Merge the metadata from all matching results.
+ // TODO(kcarattini): This is O(N^2). Look at improving performance by
+ // using a map, sorting or doing binary search etc..
+ for (const SBFullHashResult& result : full_hash_results) {
+ for (const SBFullHash& full_hash : check->full_hashes()) {
+ if (SBFullHashEqual(full_hash, result.hash)) {
+ md.api_permissions.insert(md.api_permissions.end(),
+ result.metadata.api_permissions.begin(),
+ result.metadata.api_permissions.end());
+ break;
+ }
+ }
+ }
+
+ check->client()->OnCheckApiBlacklistUrlResult(check->url(), md);
}
SafeBrowsingDatabaseManager::SafeBrowsingApiCheck::SafeBrowsingApiCheck(
« no previous file with comments | « components/safe_browsing_db/database_manager.h ('k') | components/safe_browsing_db/database_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698