SafeBrowsing: Adds response handler for API blacklist check in Database Manager.

components/safe_browsing_db/database_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/safe_browsing_db/database_manager.h"
 
 #include "components/safe_browsing_db/v4_get_hash_protocol_manager.h"
 #include "content/public/browser/browser_thread.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "url/gurl.h"
@@ skipping 68 matching lines @@
                  base::Unretained(this), check));
 
   return false;
 }
 
 void SafeBrowsingDatabaseManager::HandleGetHashesWithApisResults(
     std::shared_ptr<SafeBrowsingApiCheck> check,
     const std::vector<SBFullHashResult>& full_hash_results,
     const base::TimeDelta& negative_cache_duration) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
-  // TODO(kcarattini): Implement response handler.
+  DCHECK(check);

[Nathan Parker, 2016/04/15 23:22:00]

Sounds like a microphone check.  "Check. Check. Check one two."

[kcarattini, 2016/04/18 07:12:02]

Acknowledged.

+
+  ThreatMetadata md;
+  // Merge the metadata from all matching results.
+  for (const SBFullHashResult& result : full_hash_results) {

[Nathan Parker, 2016/04/15 23:22:00]

This is sort of O(N^2), where N is small but could easily be 10.  Maybe add a
todo to look at performance? This could be optimized by making one of them a
map, or sorting them and doing a binary search, etc.

[kcarattini, 2016/04/18 07:12:02]

Done.

+    for (const SBFullHash& full_hash : check->full_hashes()) {
+      if (SBFullHashEqual(full_hash, result.hash)) {
+        md.api_permissions.insert(md.api_permissions.end(),
+                                  result.metadata.api_permissions.begin(),
+                                  result.metadata.api_permissions.end());
+        break;
+      }
+    }
+  }
+
+  check->client()->OnCheckApiBlacklistUrlResult(check->url(), md);

[Nathan Parker, 2016/04/15 23:22:00]

Consider if we need the URL to be passed here, and remove it if not.
Some of the other client->methods have some fields they don't need.

[kcarattini, 2016/04/18 07:12:02]

I can imagine a client making calls for multiple urls and needing to know which
one the reply is for. I think it's useful.

[Nathan Parker, 2016/04/18 17:34:09]

k.  Another approach is that the caller could use different client objects, so
they can keep track of whatever state they want in them.

I think the localdbmanager has the requirement that any single client ptr can
have at most one outstanding callback.  Otherwise, when you cancel(client), it
wouldn't know which one to cancel.

 }
 
 SafeBrowsingDatabaseManager::SafeBrowsingApiCheck::SafeBrowsingApiCheck(
     const GURL& url, const std::vector<SBFullHash>& full_hashes, Client* client)
         : url_(url), full_hashes_(full_hashes), client_(client) {
 }
 
 SafeBrowsingDatabaseManager::SafeBrowsingApiCheck::~SafeBrowsingApiCheck() {
 }
 
 }  // namespace safe_browsing