Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1881343002: Revert of Update blimp build bot args match build/args/blimp_engine.gn (Closed)

Created:
4 years, 8 months ago by nednguyen
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, maniscalco
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update blimp build bot args match build/args/blimp_engine.gn (patchset #4 id:60001 of https://codereview.chromium.org/1878273003/ ) Reason for revert: Speculative revert: this breaks page_cycler.intl_hi_ru and page_cycler.intl_es_fr_pt-BR benchmarks Original issue's description: > Update blimp build bot args match build/args/blimp_engine.gn > > Reorder args so it's easier to spot differences. > > Remove gyp_defines because blimp is not designed to build with gyp. > > BUG=602696 > > Committed: https://crrev.com/55bf089c901fb38204b642edc847b6259697ee9e > Cr-Commit-Position: refs/heads/master@{#386760} TBR=dpranke@chromium.org,maniscalco@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=602696 Committed: https://crrev.com/76edf5cc66829c9a2aed30dab102de2cc16da1c7 Cr-Commit-Position: refs/heads/master@{#386912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M build/args/blimp_engine.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nednguyen
Created Revert of Update blimp build bot args match build/args/blimp_engine.gn
4 years, 8 months ago (2016-04-13 04:06:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881343002/1
4 years, 8 months ago (2016-04-13 04:06:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 04:06:42 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/76edf5cc66829c9a2aed30dab102de2cc16da1c7 Cr-Commit-Position: refs/heads/master@{#386912}
4 years, 8 months ago (2016-04-13 04:07:47 UTC) #5
Dirk Pranke
4 years, 8 months ago (2016-04-13 04:28:08 UTC) #6
Message was sent while issue was closed.
On 2016/04/13 04:07:47, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/76edf5cc66829c9a2aed30dab102de2cc16da1c7
> Cr-Commit-Position: refs/heads/master@{#386912}

It seems really unlikely that this would've broken a page_cycler test; this
should've
only affected the official blimp-engine bot.

Can you point me at the failures?

Powered by Google App Engine
This is Rietveld 408576698