Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: mojo/system/core_impl.h

Issue 188133002: Mojo: Move comment (per TODO). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/system/core_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/system/core_impl.h
diff --git a/mojo/system/core_impl.h b/mojo/system/core_impl.h
index 06e73450adb523a345c526202d7bccbc7245527b..7e226948c50b498d2cc7c6d728c9abfc1da240eb 100644
--- a/mojo/system/core_impl.h
+++ b/mojo/system/core_impl.h
@@ -117,15 +117,6 @@ class MOJO_SYSTEM_IMPL_EXPORT CoreImpl : public Core {
// handle is marked busy. If it is, it fails (with |MOJO_RESULT_BUSY|). This
// prevents |WriteMessage()| from sending a handle that has been closed (or
// learning about this too late).
- //
- // TODO(vtl): Move this implementation note.
- // To properly cancel waiters and avoid other races, |WriteMessage()| does not
- // transfer dispatchers from one handle to another, even when sending a
- // message in-process. Instead, it must transfer the "contents" of the
- // dispatcher to a new dispatcher, and then close the old dispatcher. If this
- // isn't done, in the in-process case, calls on the old handle may complete
- // after the the message has been received and a new handle created (and
- // possibly even after calls have been made on the new handle).
struct HandleTableEntry {
HandleTableEntry();
explicit HandleTableEntry(const scoped_refptr<Dispatcher>& dispatcher);
« no previous file with comments | « no previous file | mojo/system/core_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698