Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1881323002: Flip WebKit Mac 10.9 to be a builder/tester. (Closed)

Created:
4 years, 8 months ago by Dirk Pranke
Modified:
4 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Flip WebKit Mac 10.9 to be a builder/tester. For some reason the Mac10.9 bot is generating different layout test baselines than then mac_blink_rel trybots. It appears that the system images are the same and the compile flags are the same. The next working hypothesis is that there's some difference resulting from building on 10.11 and testing on 10.9 versus building on 10.9 and testing directly; the most likely culprit seems to be Xcode, which has different versions on the two bots. TBR=iannucci@chromium.org BUG=601166 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -217 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_9.json View 6 chunks +71 lines, -178 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac_Builder.json View 2 chunks +0 lines, -37 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dirk Pranke
TBR'ing as we discussed.
4 years, 8 months ago (2016-04-13 02:18:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881323002/1
4 years, 8 months ago (2016-04-13 02:22:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299879
4 years, 8 months ago (2016-04-13 02:26:25 UTC) #5
Dirk Pranke
On 2016/04/13 02:26:25, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 8 months ago (2016-04-13 04:33:15 UTC) #6
iannucci
4 years, 8 months ago (2016-04-13 08:20:39 UTC) #7
Message was sent while issue was closed.
On 2016/04/13 at 04:33:15, dpranke wrote:
> On 2016/04/13 02:26:25, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> > http://src.chromium.org/viewvc/chrome?view=rev&revision=299879
> 
> Sadly, that doesn't appear to have fixed things, either.
> 
> I guess the next steps are probably to reimage one of the tryservers to be
sure, and
> to take the 10.9 bot offline, take one of the tryservers offline, and try to
figure out
> what the differences are.

bummer :/

Powered by Google App Engine
This is Rietveld 408576698