Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1881313002:
Make win_clang bot use the lld linker. (Closed)
|
Created:
4 years, 8 months ago by Nico Modified:
4 years, 6 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake win_clang bot use the lld linker.
lld can't create .pdb files yet, but win_clang doesn't run any tests, so
that's ok.
I'd like to check if this improves cycle time, and if so, how much. I might
revert this again in a day or two.
Depends on https://llvm.org/bugs/show_bug.cgi?id=27335
BUG=none
Committed: https://crrev.com/3aba1a0af10235c54db7253c46525825c1cf2c38
Cr-Commit-Position: refs/heads/master@{#396205}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase #Patch Set 4 : rebase #Messages
Total messages: 21 (12 generated)
thakis@chromium.org changed reviewers: + dpranke@chromium.org
Oh, I'm not sure what this will do to build performance – I'd like to land this and watch the bot stats a bit.
lgtm
Description was changed from ========== Make win_clang bot use the lld linker. MSVC's linker has an incremental linking mode. In 2015, this mode is pretty buggy -- it crashes when linking mesa.dll (we disabled incremental linking for that target), and it sometimes emits errors about "invalid .pdata contributions" when linking .obj files created by clang. The latter part might be clang-cl's fault, but we haven't heard back on our bug report yet. Until this is figured out, switch the win_clang bot to use the lld linker instead, which should be more stable. (It can't create .pdb files yet, but win_clang doesn't run any tests, so that's ok.) BUG=595702 ========== to ========== Make win_clang bot use the lld linker. MSVC's linker has an incremental linking mode. In 2015, this mode is pretty buggy -- it crashes when linking mesa.dll (we disabled incremental linking for that target), and it sometimes emits errors about "invalid .pdata contributions" when linking .obj files created by clang. The latter part might be clang-cl's fault, but we haven't heard back on our bug report yet. Until this is figured out, switch the win_clang bot to use the lld linker instead, which should be more stable. (It can't create .pdb files yet, but win_clang doesn't run any tests, so that's ok.) Depends on https://llvm.org/bugs/show_bug.cgi?id=27335 BUG=595702 ==========
Patchset #2 (id:20001) has been deleted
Description was changed from ========== Make win_clang bot use the lld linker. MSVC's linker has an incremental linking mode. In 2015, this mode is pretty buggy -- it crashes when linking mesa.dll (we disabled incremental linking for that target), and it sometimes emits errors about "invalid .pdata contributions" when linking .obj files created by clang. The latter part might be clang-cl's fault, but we haven't heard back on our bug report yet. Until this is figured out, switch the win_clang bot to use the lld linker instead, which should be more stable. (It can't create .pdb files yet, but win_clang doesn't run any tests, so that's ok.) Depends on https://llvm.org/bugs/show_bug.cgi?id=27335 BUG=595702 ========== to ========== Make win_clang bot use the lld linker. lld can't create .pdb files yet, but win_clang doesn't run any tests, so that's ok. I'd like to check if this improves cycle time, and if so, how much. I might revert this again in a day or two. Depends on https://llvm.org/bugs/show_bug.cgi?id=27335 BUG=595702 ==========
Description was changed from ========== Make win_clang bot use the lld linker. lld can't create .pdb files yet, but win_clang doesn't run any tests, so that's ok. I'd like to check if this improves cycle time, and if so, how much. I might revert this again in a day or two. Depends on https://llvm.org/bugs/show_bug.cgi?id=27335 BUG=595702 ========== to ========== Make win_clang bot use the lld linker. lld can't create .pdb files yet, but win_clang doesn't run any tests, so that's ok. I'd like to check if this improves cycle time, and if so, how much. I might revert this again in a day or two. Depends on https://llvm.org/bugs/show_bug.cgi?id=27335 BUG=none ==========
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/1881313002/#ps60001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881313002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881313002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/1881313002/#ps80001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881313002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881313002/80001
Message was sent while issue was closed.
Description was changed from ========== Make win_clang bot use the lld linker. lld can't create .pdb files yet, but win_clang doesn't run any tests, so that's ok. I'd like to check if this improves cycle time, and if so, how much. I might revert this again in a day or two. Depends on https://llvm.org/bugs/show_bug.cgi?id=27335 BUG=none ========== to ========== Make win_clang bot use the lld linker. lld can't create .pdb files yet, but win_clang doesn't run any tests, so that's ok. I'd like to check if this improves cycle time, and if so, how much. I might revert this again in a day or two. Depends on https://llvm.org/bugs/show_bug.cgi?id=27335 BUG=none ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Make win_clang bot use the lld linker. lld can't create .pdb files yet, but win_clang doesn't run any tests, so that's ok. I'd like to check if this improves cycle time, and if so, how much. I might revert this again in a day or two. Depends on https://llvm.org/bugs/show_bug.cgi?id=27335 BUG=none ========== to ========== Make win_clang bot use the lld linker. lld can't create .pdb files yet, but win_clang doesn't run any tests, so that's ok. I'd like to check if this improves cycle time, and if so, how much. I might revert this again in a day or two. Depends on https://llvm.org/bugs/show_bug.cgi?id=27335 BUG=none Committed: https://crrev.com/3aba1a0af10235c54db7253c46525825c1cf2c38 Cr-Commit-Position: refs/heads/master@{#396205} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/3aba1a0af10235c54db7253c46525825c1cf2c38 Cr-Commit-Position: refs/heads/master@{#396205}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:80001) has been created in https://codereview.chromium.org/2010963004/ by thakis@chromium.org. The reason for reverting is: Looks like this is much slower than link.exe.. |
