Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 1881293002: dart2js: use IdGenerator for all id generation (Closed)

Created:
4 years, 8 months ago by Harry Terkelsen
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +1 line, -5 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
4 years, 8 months ago (2016-04-13 00:21:44 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 8 months ago (2016-04-13 15:59:34 UTC) #3
Harry Terkelsen
4 years, 8 months ago (2016-04-13 16:02:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
acf33e480c77a090f1537352add073f90af0702b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698