Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1881283002: Update Chromium docs on using clang (Closed)

Created:
4 years, 8 months ago by Reid Kleckner
Modified:
4 years, 8 months ago
Reviewers:
hans, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Chromium docs on using clang - Goma should work with clang on Windows - Mention LLD - Rearrange the build instructions, people probably just want to see the GYP_DEFINES and args.gn first R=thakis@chromium.org,hans@chromium.org Committed: https://crrev.com/c052ba3783ce522a860c9fe981dff01f339fbdc1 Cr-Commit-Position: refs/heads/master@{#387089}

Patch Set 1 #

Total comments: 4

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M docs/clang.md View 1 5 chunks +28 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Reid Kleckner
4 years, 8 months ago (2016-04-12 23:08:01 UTC) #1
Nico
lgtm! https://codereview.chromium.org/1881283002/diff/1/docs/clang.md File docs/clang.md (right): https://codereview.chromium.org/1881283002/diff/1/docs/clang.md#newcode17 docs/clang.md:17: ### Ninja (we can probably drop this heading ...
4 years, 8 months ago (2016-04-13 00:50:14 UTC) #2
Reid Kleckner
https://codereview.chromium.org/1881283002/diff/1/docs/clang.md File docs/clang.md (right): https://codereview.chromium.org/1881283002/diff/1/docs/clang.md#newcode91 docs/clang.md:91: On 2016/04/13 00:50:14, Nico wrote: > mention somewhere here ...
4 years, 8 months ago (2016-04-13 18:11:47 UTC) #3
Nico
https://codereview.chromium.org/1881283002/diff/1/docs/clang.md File docs/clang.md (right): https://codereview.chromium.org/1881283002/diff/1/docs/clang.md#newcode91 docs/clang.md:91: On 2016/04/13 18:11:47, Reid Kleckner wrote: > On 2016/04/13 ...
4 years, 8 months ago (2016-04-13 18:13:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881283002/20001
4 years, 8 months ago (2016-04-13 20:38:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 21:13:09 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 21:14:44 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c052ba3783ce522a860c9fe981dff01f339fbdc1
Cr-Commit-Position: refs/heads/master@{#387089}

Powered by Google App Engine
This is Rietveld 408576698