Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1881273002: Revert of Add download_file_types.proto with ascii->binary conversion, as a resource. (Closed)

Created:
4 years, 8 months ago by Not at Google. Contact bengr
Modified:
4 years, 8 months ago
CC:
arv+watch_chromium.org, chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add download_file_types.proto with ascii->binary conversion, as a resource. (patchset #7 id:120001 of https://codereview.chromium.org/1857983002/ ) Reason for revert: This cl is breaking Android Debug (Nexus 5): https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus%205%29/builds/7159 Error log: FAILED: python ../../chrome/browser/resources/safe_browsing/gen_file_type_proto.py -i ../../chrome/browser/resources/safe_browsing/download_file_types.asciipb -o gen/chrome/browser/resources/safe_browsing/download_file_types.pb -p pyproto/chrome/common/safe_browsing Traceback (most recent call last): File "../../chrome/browser/resources/safe_browsing/gen_file_type_proto.py", line 13, in <module> import google.protobuf.text_format as text_format ImportError: No module named google.protobuf.text_format ninja: build stopped: subcommand failed. Original issue's description: > Add download_file_types.proto with ascii->binary conversion, as a resource. > > We'll maintain an ASCII version of the data in the repo, and build > the binary version as a Resource at build time. The data will later be > updated at runtime. > > BUG=596555 > > Committed: https://crrev.com/d57ee6f2e12ac55ac832ca36429545e370467290 > Cr-Commit-Position: refs/heads/master@{#386818} TBR=asanka@chromium.org,jialiul@chromium.org,jialiul@google.com,thestig@chromium.org,nparker@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=596555 Committed: https://crrev.com/6834929f54cd4dfbdd926ebb1f34edff98d32027 Cr-Commit-Position: refs/heads/master@{#386841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -349 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/resources/safe_browsing/BUILD.gn View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/resources/safe_browsing/README.md View 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/browser/resources/safe_browsing/download_file_types.asciipb View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/resources/safe_browsing/gen_file_type_proto.py View 1 chunk +0 lines, -59 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/chrome_resources.gyp View 2 chunks +0 lines, -38 lines 0 comments Download
M chrome/common/safe_browsing/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/safe_browsing/download_file_types.proto View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Not at Google. Contact bengr
Created Revert of Add download_file_types.proto with ascii->binary conversion, as a resource.
4 years, 8 months ago (2016-04-12 23:07:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881273002/1
4 years, 8 months ago (2016-04-12 23:07:57 UTC) #2
Jialiu Lin
lgtm
4 years, 8 months ago (2016-04-12 23:08:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 23:09:25 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 23:10:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6834929f54cd4dfbdd926ebb1f34edff98d32027
Cr-Commit-Position: refs/heads/master@{#386841}

Powered by Google App Engine
This is Rietveld 408576698