Generalize support for per-display shelf prefs.

Generalize support for per-display shelf prefs.

Move preference helpers to chrome_launcher_prefs.
Refactor to take a display ID instead of a root window.
This helps facilitate similar functionality in mash.

BUG=557406
TEST=Chrome OS per-display shelf prefs still work.
R=oshima@chromium.org

Committed: https://crrev.com/f2eb2d51e455e5a0c5fd6d0287e00cdff4dacd55
Cr-Commit-Position: refs/heads/master@{#387447}

[msw, 2016-04-12 23:11:08]

Patchset #2 (id:20001) has been deleted

[msw, 2016-04-12 23:11:37]

Description was changed from

==========
Generalize support for per-display shelf prefs.

Move preference helpers to chrome_launcher_prefs.
Refactor to take a display ID instead of a root window.

BUG=557406
TEST=Chrome OS per-display shelf prefs still work.
R=oshima@chromium.org
==========

to

==========
Generalize support for per-display shelf prefs.

Move preference helpers to chrome_launcher_prefs.
Refactor to take a display ID instead of a root window.
This helps facilitate similar functionality in mash.

BUG=557406
TEST=Chrome OS per-display shelf prefs still work.
R=oshima@chromium.org
==========

[msw, 2016-04-12 23:20:41]

Hey Oshima, please take a look; thanks!
Maybe this will help diagnose http://crbug.com/602643 ?

[msw, 2016-04-12 23:21:15]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 23:21:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881263002/40001

[commit-bot: I haz the power, 2016-04-13 01:04:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 01:04:31]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[msw, 2016-04-14 18:47:26]

Oshima, friendly ping, please take a look; thanks!

[oshima, 2016-04-14 19:26:17]

https://codereview.chromium.org/1881263002/diff/40001/chrome/browser/ui/ash/c...
File chrome/browser/ui/ash/chrome_launcher_prefs.h (right):

https://codereview.chromium.org/1881263002/diff/40001/chrome/browser/ui/ash/c...
chrome/browser/ui/ash/chrome_launcher_prefs.h:12: class Profile;
can we instead use PrefSerivce?

[msw, 2016-04-14 20:39:26]

Please take another look; thanks!

https://codereview.chromium.org/1881263002/diff/40001/chrome/browser/ui/ash/c...
File chrome/browser/ui/ash/chrome_launcher_prefs.h (right):

https://codereview.chromium.org/1881263002/diff/40001/chrome/browser/ui/ash/c...
chrome/browser/ui/ash/chrome_launcher_prefs.h:12: class Profile;
On 2016/04/14 19:26:17, oshima wrote:
> can we instead use PrefSerivce?

Done.

[oshima, 2016-04-14 20:56:26]

lgtm

[msw, 2016-04-14 21:13:28]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-04-14 21:13:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881263002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881263002/60001

[commit-bot: I haz the power, 2016-04-14 22:29:29]

Description was changed from

==========
Generalize support for per-display shelf prefs.

Move preference helpers to chrome_launcher_prefs.
Refactor to take a display ID instead of a root window.
This helps facilitate similar functionality in mash.

BUG=557406
TEST=Chrome OS per-display shelf prefs still work.
R=oshima@chromium.org
==========

to

==========
Generalize support for per-display shelf prefs.

Move preference helpers to chrome_launcher_prefs.
Refactor to take a display ID instead of a root window.
This helps facilitate similar functionality in mash.

BUG=557406
TEST=Chrome OS per-display shelf prefs still work.
R=oshima@chromium.org
==========

[commit-bot: I haz the power, 2016-04-14 22:29:30]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-04-14 22:30:32]

Description was changed from

==========
Generalize support for per-display shelf prefs.

Move preference helpers to chrome_launcher_prefs.
Refactor to take a display ID instead of a root window.
This helps facilitate similar functionality in mash.

BUG=557406
TEST=Chrome OS per-display shelf prefs still work.
R=oshima@chromium.org
==========

to

==========
Generalize support for per-display shelf prefs.

Move preference helpers to chrome_launcher_prefs.
Refactor to take a display ID instead of a root window.
This helps facilitate similar functionality in mash.

BUG=557406
TEST=Chrome OS per-display shelf prefs still work.
R=oshima@chromium.org

Committed: https://crrev.com/f2eb2d51e455e5a0c5fd6d0287e00cdff4dacd55
Cr-Commit-Position: refs/heads/master@{#387447}
==========

[commit-bot: I haz the power, 2016-04-14 22:30:33]

Patchset 3 (id:??) landed as
https://crrev.com/f2eb2d51e455e5a0c5fd6d0287e00cdff4dacd55
Cr-Commit-Position: refs/heads/master@{#387447}