Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: components/prefs/in_memory_pref_store_unittest.cc

Issue 1881253003: Create a PrefStore in support of Blimp metrics collection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fix conflict with ptr migration work. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/prefs/in_memory_pref_store.cc ('k') | components/prefs/prefs.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/prefs/in_memory_pref_store_unittest.cc
diff --git a/components/prefs/in_memory_pref_store_unittest.cc b/components/prefs/in_memory_pref_store_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d8467945611c156ea7889f62c2dd2dc3d844d363
--- /dev/null
+++ b/components/prefs/in_memory_pref_store_unittest.cc
@@ -0,0 +1,105 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/prefs/in_memory_pref_store.h"
+
+#include "base/memory/ptr_util.h"
+#include "base/values.h"
+#include "components/prefs/pref_store_observer_mock.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+namespace {
+const char kTestPref[] = "test.pref";
+
+class InMemoryPrefStoreTest : public testing::Test {
+ public:
+ InMemoryPrefStoreTest() { }
+
+ void SetUp() override { store_ = new InMemoryPrefStore(); }
+ protected:
+ scoped_refptr<InMemoryPrefStore> store_;
+ PrefStoreObserverMock observer_;
+};
+
+TEST_F(InMemoryPrefStoreTest, SetGetValue) {
+ const base::Value* value = NULL;
+ base::Value* mutable_value = NULL;
+ EXPECT_FALSE(store_->GetValue(kTestPref, &value));
+ EXPECT_FALSE(store_->GetMutableValue(kTestPref, &mutable_value));
+
+ store_->SetValue(kTestPref, base::WrapUnique(new base::FundamentalValue(42)),
+ WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
+ EXPECT_TRUE(store_->GetValue(kTestPref, &value));
+ EXPECT_TRUE(base::FundamentalValue(42).Equals(value));
+ EXPECT_TRUE(store_->GetMutableValue(kTestPref, &mutable_value));
+ EXPECT_TRUE(base::FundamentalValue(42).Equals(mutable_value));
+
+ store_->RemoveValue(kTestPref, WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
+ EXPECT_FALSE(store_->GetValue(kTestPref, &value));
+ EXPECT_FALSE(store_->GetMutableValue(kTestPref, &mutable_value));
+}
+
+TEST_F(InMemoryPrefStoreTest, GetSetObserver) {
+ // Starts with no observers.
+ EXPECT_FALSE(store_->HasObservers());
+
+ // Add one.
+ store_->AddObserver(&observer_);
+ EXPECT_TRUE(store_->HasObservers());
+
+ // Remove only observer.
+ store_->RemoveObserver(&observer_);
+ EXPECT_FALSE(store_->HasObservers());
+}
+
+TEST_F(InMemoryPrefStoreTest, CallObserver) {
+ // With observer included.
+ store_->AddObserver(&observer_);
+
+ // Triggers on SetValue.
+ store_->SetValue(kTestPref, base::WrapUnique(new base::FundamentalValue(42)),
+ WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
+ observer_.VerifyAndResetChangedKey(kTestPref);
+
+ // And RemoveValue.
+ store_->RemoveValue(kTestPref, WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
+ observer_.VerifyAndResetChangedKey(kTestPref);
+
+ // But not SetValueSilently.
+ store_->SetValueSilently(kTestPref,
+ base::WrapUnique(new base::FundamentalValue(42)),
+ WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
+ EXPECT_EQ(0u, observer_.changed_keys.size());
+
+ // On multiple RemoveValues only the first one triggers observer.
+ store_->RemoveValue(kTestPref, WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
+ observer_.VerifyAndResetChangedKey(kTestPref);
+ store_->RemoveValue(kTestPref, WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
+ EXPECT_EQ(0u, observer_.changed_keys.size());
+
+ // Doesn't make call on removed observers.
+ store_->RemoveObserver(&observer_);
+ store_->SetValue(kTestPref, base::WrapUnique(new base::FundamentalValue(42)),
+ WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
+ store_->RemoveValue(kTestPref, WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
+ EXPECT_EQ(0u, observer_.changed_keys.size());
+}
+
+TEST_F(InMemoryPrefStoreTest, Initialization) {
+ EXPECT_TRUE(store_->IsInitializationComplete());
+}
+
+TEST_F(InMemoryPrefStoreTest, ReadOnly) {
+ EXPECT_FALSE(store_->ReadOnly());
+}
+
+TEST_F(InMemoryPrefStoreTest, GetReadError) {
+ EXPECT_EQ(PersistentPrefStore::PREF_READ_ERROR_NONE, store_->GetReadError());
+}
+
+TEST_F(InMemoryPrefStoreTest, ReadPrefs) {
+ EXPECT_EQ(PersistentPrefStore::PREF_READ_ERROR_NONE, store_->ReadPrefs());
+}
+
+} // namespace
« no previous file with comments | « components/prefs/in_memory_pref_store.cc ('k') | components/prefs/prefs.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698