Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipe_modules/chromium_tests/steps.py

Issue 1881233003: Reland Switch Android gtests to use generated wrapper scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: attempted fix Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/chromium_android/example.expected/webview_tester_basic.json ('k') | scripts/slave/recipe_modules/cronet/example.expected/local_test.json » ('j') | scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_tests/steps.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/steps.py b/scripts/slave/recipe_modules/chromium_tests/steps.py
index e0458668b22c9b96d4e3e13dd79f7ba571816505..196a6f12c6011ae7e6d1d8f83d84dd180e5294e4 100644
--- a/scripts/slave/recipe_modules/chromium_tests/steps.py
+++ b/scripts/slave/recipe_modules/chromium_tests/steps.py
@@ -272,8 +272,9 @@ class LocalGTestTest(Test):
if self._override_compile_targets:
return self._override_compile_targets
+ # TODO(GYP) Remove special case once fully converted to GN.
if api.chromium.c.TARGET_PLATFORM == 'android':
- return [self.target_name + '_apk']
+ return [self.target_name, self.target_name + '_apk']
return [self.target_name]
« no previous file with comments | « scripts/slave/recipe_modules/chromium_android/example.expected/webview_tester_basic.json ('k') | scripts/slave/recipe_modules/cronet/example.expected/local_test.json » ('j') | scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Builder__dbg_.json » ('J')

Powered by Google App Engine
This is Rietveld 408576698