Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1881233002:
DevTools: workaround bug in Blink selection API (Closed)
|
Created:
4 years, 8 months ago by lushnikov Modified:
4 years, 8 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: workaround bug in Blink selection API
The patch works around the bug in the blink selection API, when the
selection.rangeCount returns 1, but selection.getRangeAt(0) still returns
null.
BUG=602541, 595100
R=dgozman, pfeldman_ooo
Committed: https://crrev.com/7eb9fc98d4038fc256ab580bb7f61ce796117d68
Cr-Commit-Position: refs/heads/master@{#387121}
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 34 (17 generated)
ptal
Description was changed from ========== DevTools: workaround bug in Blink selection API The patch works around the bug in the blink selection API, when the selection.rangeCount returns 1, but selection.getRangeAt(0) still returns null. BUG=602541 R=dgozman, pfeldman_ooo ========== to ========== DevTools: workaround bug in Blink selection API The patch works around the bug in the blink selection API, when the selection.rangeCount returns 1, but selection.getRangeAt(0) still returns null. BUG=602541, 595100 R=dgozman, pfeldman_ooo ==========
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881233002/1
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881233002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881233002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881233002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881233002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by lushnikov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/1881233002/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881233002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881233002/20001
Message was sent while issue was closed.
Description was changed from ========== DevTools: workaround bug in Blink selection API The patch works around the bug in the blink selection API, when the selection.rangeCount returns 1, but selection.getRangeAt(0) still returns null. BUG=602541, 595100 R=dgozman, pfeldman_ooo ========== to ========== DevTools: workaround bug in Blink selection API The patch works around the bug in the blink selection API, when the selection.rangeCount returns 1, but selection.getRangeAt(0) still returns null. BUG=602541, 595100 R=dgozman, pfeldman_ooo ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== DevTools: workaround bug in Blink selection API The patch works around the bug in the blink selection API, when the selection.rangeCount returns 1, but selection.getRangeAt(0) still returns null. BUG=602541, 595100 R=dgozman, pfeldman_ooo ========== to ========== DevTools: workaround bug in Blink selection API The patch works around the bug in the blink selection API, when the selection.rangeCount returns 1, but selection.getRangeAt(0) still returns null. BUG=602541, 595100 R=dgozman, pfeldman_ooo Committed: https://crrev.com/7eb9fc98d4038fc256ab580bb7f61ce796117d68 Cr-Commit-Position: refs/heads/master@{#387121} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7eb9fc98d4038fc256ab580bb7f61ce796117d68 Cr-Commit-Position: refs/heads/master@{#387121} |
