scripts/slave/recipes/findit/chromium/compile.py - Issue 1881223002: [Findit] Set culprit and infra failure explicitly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/findit/chromium/compile.py

Issue 1881223002: [Findit] Set culprit and infra failure explicitly. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/findit/chromium/compile.py

diff --git a/scripts/slave/recipes/findit/chromium/compile.py b/scripts/slave/recipes/findit/chromium/compile.py

index 6ec58d194f6ea1e22f9ba03503576a3188b3b332..ac64257cf7936ba527d8380e8760ecc3621ace2e 100644

--- a/scripts/slave/recipes/findit/chromium/compile.py

+++ b/scripts/slave/recipes/findit/chromium/compile.py

@@ -234,8 +234,12 @@ def RunSteps(api, target_mastername, target_buildername,

found = True

except api.step.InfraFailure:

compile_results[revision_being_checked] = CompileResult.INFRA_FAILED

+ report['metadata']['infra_failure'] = True

raise

finally:

+ if found:

+ report['culprit'] = suspected_revision

# Report the result.

step_result = api.python.succeeding_step(

'report', [json.dumps(report, indent=2)], as_log='report')

« no previous file with comments | « no previous file | scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json » ('j') | no next file with comments »