Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 18812005: Fix build breakage after 15630 (Closed)

Created:
7 years, 5 months ago by danno
Modified:
7 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Fix build breakage after 15630 Use EXTRA_CALL_FRAME rather than NO_EXTRA_FRAME in ElementsTransitionAndStoreIC_Miss. TBR=bmeurer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ic.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
7 years, 5 months ago (2013-07-11 16:24:49 UTC) #1
danno
Committed patchset #1 manually as r15637 (presubmit successful).
7 years, 5 months ago (2013-07-11 16:26:04 UTC) #2
Benedikt Meurer
7 years, 5 months ago (2013-07-11 17:18:25 UTC) #3
Message was sent while issue was closed.
Wow, that's weird. I'm pretty sure it passed make check prior to rebasing.
Anyway, that's LGTM of course.

Powered by Google App Engine
This is Rietveld 408576698