Add GN arg to optimize for size

Add GN arg to optimize for size

BUG=internal b/27889508

Committed: https://crrev.com/3bca76f6d2a14ba232c08fa133d0186679a3f78e
Cr-Commit-Position: refs/heads/master@{#386826}

[bcf, 2016-04-12 20:22:29]

Description was changed from

==========
Add GN arg to optimize for size

BUG=internal b/27889508
==========

to

==========
Add GN arg to optimize for size

BUG=internal b/27889508
==========

[bcf, 2016-04-12 20:22:29]

bcf@chromium.org changed reviewers:
+ dpranke@chromium.org, halliwell@chromium.org, slan@chromium.org

[bcf, 2016-04-12 20:24:04]

For Chromecast we would like to have the option to conditionally specify -Os for
some builds.

[slan, 2016-04-12 20:34:37]

https://codereview.chromium.org/1881193002/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1881193002/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:85: optimize_size = false
nit: optimize_for_size

https://codereview.chromium.org/1881193002/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:1215: } else if (optimize_size || is_android ||
is_ios) {
nit: What about making this condition simply 

} else if(optimize_for_size) {

and set the default to (is_android || is_ios) in the declare_args block?

[bcf, 2016-04-12 20:47:13]

https://codereview.chromium.org/1881193002/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1881193002/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:85: optimize_size = false
On 2016/04/12 20:34:37, slan wrote:
> nit: optimize_for_size

Done.

https://codereview.chromium.org/1881193002/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:1215: } else if (optimize_size || is_android ||
is_ios) {
On 2016/04/12 20:34:37, slan wrote:
> nit: What about making this condition simply 
> 
> } else if(optimize_for_size) {
> 
> and set the default to (is_android || is_ios) in the declare_args block?
> 

Done.

[slan, 2016-04-12 20:50:19]

This change l-g-t-m, but let's hear what Dirk thinks.

https://codereview.chromium.org/1881193002/diff/20001/build/config/compiler/B...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1881193002/diff/20001/build/config/compiler/B...
build/config/compiler/BUILD.gn:1219: # Linux & Mac favor speed over size.
nit: It might make more sense now to move this comment up to the flag
declaration (where you've assigned the default value based on the platform)

[bcf, 2016-04-12 20:54:38]

https://codereview.chromium.org/1881193002/diff/20001/build/config/compiler/B...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1881193002/diff/20001/build/config/compiler/B...
build/config/compiler/BUILD.gn:1219: # Linux & Mac favor speed over size.
On 2016/04/12 20:50:19, slan wrote:
> nit: It might make more sense now to move this comment up to the flag
> declaration (where you've assigned the default value based on the platform)
> 

Done.

[Dirk Pranke, 2016-04-12 20:55:08]

lgtm

[bcf, 2016-04-12 20:56:23]

The CQ bit was checked by bcf@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 20:56:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881193002/40001

[commit-bot: I haz the power, 2016-04-12 21:50:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 21:50:03]

Dry run: This issue passed the CQ dry run.

[bcf, 2016-04-12 21:57:51]

The CQ bit was checked by bcf@chromium.org

[commit-bot: I haz the power, 2016-04-12 21:58:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881193002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881193002/40001

[commit-bot: I haz the power, 2016-04-12 22:06:02]

Description was changed from

==========
Add GN arg to optimize for size

BUG=internal b/27889508
==========

to

==========
Add GN arg to optimize for size

BUG=internal b/27889508
==========

[commit-bot: I haz the power, 2016-04-12 22:06:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-12 22:08:01]

Description was changed from

==========
Add GN arg to optimize for size

BUG=internal b/27889508
==========

to

==========
Add GN arg to optimize for size

BUG=internal b/27889508

Committed: https://crrev.com/3bca76f6d2a14ba232c08fa133d0186679a3f78e
Cr-Commit-Position: refs/heads/master@{#386826}
==========

[commit-bot: I haz the power, 2016-04-12 22:08:02]

Patchset 3 (id:??) landed as
https://crrev.com/3bca76f6d2a14ba232c08fa133d0186679a3f78e
Cr-Commit-Position: refs/heads/master@{#386826}