Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1881123003: annotated_run: extract CipdBinary so it can be shared with kitchen_run (Closed)

Created:
4 years, 8 months ago by Paweł Hajdan Jr.
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

annotated_run: extract CipdBinary so it can be shared with kitchen_run This will be needed for https://codereview.chromium.org/1869053002 BUG=chromium:593999 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299893

Patch Set 1 #

Patch Set 2 : presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -40 lines) Patch
M scripts/slave/annotated_run.py View 10 chunks +60 lines, -34 lines 0 comments Download
M scripts/slave/cipd.py View 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/unittests/annotated_run_test.py View 1 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881123003/1
4 years, 8 months ago (2016-04-13 12:04:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881123003/20001
4 years, 8 months ago (2016-04-13 12:10:04 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 12:14:19 UTC) #6
Paweł Hajdan Jr.
4 years, 8 months ago (2016-04-13 12:16:08 UTC) #8
kjellander_chromium
lgtm
4 years, 8 months ago (2016-04-13 12:22:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881123003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881123003/20001
4 years, 8 months ago (2016-04-13 14:10:26 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 14:14:43 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299893

Powered by Google App Engine
This is Rietveld 408576698