third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp - Issue 1881113002: Fix references to ISO 15924

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp

Issue 1881113002: Fix references to ISO 15924 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/payments/PaymentRequest.h ('K') | « third_party/WebKit/Source/modules/payments/PaymentsValidators.h ('k') | third_party/WebKit/public/platform/modules/payments/payment_request.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp b/third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp

index 4072b65c2877cfdacc5a5a935c0d3f5a2c411ae5..d39e36d95338bb5359bbaaf7e3e9d7400233f524 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentsValidators.cpp

@@ -5,7 +5,6 @@

#include "modules/payments/PaymentsValidators.h"

#include "bindings/core/v8/ScriptRegexp.h"

-#include "wtf/text/StringImpl.h"

please use gerrit instead 2016/04/12 20:42:31 Let's not alter includes in this patch. This patch

namespace blink {

@@ -59,7 +58,7 @@ bool PaymentsValidators::isValidScriptCodeFormat(const String& code, String* opt

return true;

if (optionalErrorMessage)

- *optionalErrorMessage = "'" + code + "' is not a valid ISO 1524 script code, should be an upper case letter [A-Z] followed by 3 lower case letters [a-z]";

+ *optionalErrorMessage = "'" + code + "' is not a valid ISO 15924 script code, should be an upper case letter [A-Z] followed by 3 lower case letters [a-z]";

return false;

}